Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2721943002:
Extend gpu driver bug fix to Kindle devices (Closed)
DescriptionExtend gpu driver bug fix to Kindle devices
The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014,
and HDX 7" 2013, all suffer the same issue that was causing Issue 670607
on Nexus 7 gen 2 devices. This change will extend that
Nexus 7 driver fix to these devices.
BUG=696627
Review-Url: https://codereview.chromium.org/2721943002
Cr-Commit-Position: refs/heads/master@{#454125}
Committed: https://chromium.googlesource.com/chromium/src/+/b5eadd9cca9f61b95d5705228e91bbe2e214a5d8
Patch Set 1 #Patch Set 2 : Update version number #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing the BUG=670607 on Nexus 7 gen 2 devices. This change would extend that Nexus 7 driver fix to these devices. BUG=696627 ========== to ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing the BUG=670607 on Nexus 7 gen 2 devices. This change would extend that Nexus 7 driver fix to these devices. BUG=696627 ==========
calvimei@amazon.com changed reviewers: + kbr@chromium.org
PTAL
Description was changed from ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing the BUG=670607 on Nexus 7 gen 2 devices. This change would extend that Nexus 7 driver fix to these devices. BUG=696627 ========== to ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing the BUG=670607 on Nexus 7 gen 2 devices. This change will extend that Nexus 7 driver fix to these devices. BUG=696627 ==========
Description was changed from ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing the BUG=670607 on Nexus 7 gen 2 devices. This change will extend that Nexus 7 driver fix to these devices. BUG=696627 ========== to ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing Issue 670607 on Nexus 7 gen 2 devices. This change will extend that Nexus 7 driver fix to these devices. BUG=696627 ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
This looks fine, but zmo@ is in the middle of rewriting how these lists are maintained so I leave the final word to him about whether to wait and ask you to re-merge this later.
trchen@chromium.org changed reviewers: + trchen@chromium.org
By the way could you share the dump of about:gpu for the affected devices? Not against filtering by model ID & GPU vendor. Just to let you know I didn't put too much thought in that decision. It'd be great if we can pinpoint the exact versions of driver having this bug. :D
trchen@chromium.org changed reviewers: - trchen@chromium.org
On 2017/03/01 23:13:12, trchen wrote: > By the way could you share the dump of about:gpu for the affected devices? > > Not against filtering by model ID & GPU vendor. Just to let you know I didn't > put too much thought in that decision. It'd be great if we can pinpoint the > exact versions of driver having this bug. :D LGTM Let's land this quickly. I am happy to rebase on top of this.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/01 23:13:12, trchen wrote: > By the way could you share the dump of about:gpu for the affected devices? > > Not against filtering by model ID & GPU vendor. Just to let you know I didn't > put too much thought in that decision. It'd be great if we can pinpoint the > exact versions of driver having this bug. :D Sure. I uploaded the about:gpu for the KFTHWI and KFAPWI devices here: https://docs.google.com/document/d/1QX62iRatZRMakr0YxvldfKkdllvvN0E-mA4GA7XMm... https://docs.google.com/document/d/1Idbw3Xc_g9ULmH75MLQFGJR3q_tchuyL7_I5n9PVH...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488411296153060,
"parent_rev": "92396f43f69b36598253b2f4cec1d93017343244", "commit_rev":
"b5eadd9cca9f61b95d5705228e91bbe2e214a5d8"}
Message was sent while issue was closed.
Description was changed from ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing Issue 670607 on Nexus 7 gen 2 devices. This change will extend that Nexus 7 driver fix to these devices. BUG=696627 ========== to ========== Extend gpu driver bug fix to Kindle devices The following Amazon Kindle Fire devices: HDX 8.9" 2013, HDX 8.9" 2014, and HDX 7" 2013, all suffer the same issue that was causing Issue 670607 on Nexus 7 gen 2 devices. This change will extend that Nexus 7 driver fix to these devices. BUG=696627 Review-Url: https://codereview.chromium.org/2721943002 Cr-Commit-Position: refs/heads/master@{#454125} Committed: https://chromium.googlesource.com/chromium/src/+/b5eadd9cca9f61b95d5705228e91... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b5eadd9cca9f61b95d5705228e91...
Message was sent while issue was closed.
On 2017/03/02 at 00:38:58, calvimei wrote: > On 2017/03/01 23:13:12, trchen wrote: > > By the way could you share the dump of about:gpu for the affected devices? > > > > Not against filtering by model ID & GPU vendor. Just to let you know I didn't > > put too much thought in that decision. It'd be great if we can pinpoint the > > exact versions of driver having this bug. :D > > Sure. I uploaded the about:gpu for the KFTHWI and KFAPWI devices here: > https://docs.google.com/document/d/1QX62iRatZRMakr0YxvldfKkdllvvN0E-mA4GA7XMm... > https://docs.google.com/document/d/1Idbw3Xc_g9ULmH75MLQFGJR3q_tchuyL7_I5n9PVH... The GL_VERSION numbers don't resemble the one on the Nexus 7 2013, so I don't think we can do better than device names. Unfortunately, Qualcomm's driver branches aren't generally reflected very well in any version number that we see.
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
