Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2721893003: enable fp16 when --enable-hdr-output is on (Closed)

Created:
3 years, 9 months ago by hubbe
Modified:
3 years, 9 months ago
Reviewers:
jbauman, ccameron
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

enable fp16 when --enable-hdr-output is on Unfortunately the VP9 profile is currently set to VP9PROFILE_PROFILE0 even when the videos are profile 2 in most cases, until we get that fixed we'll enable fp16 mode whenever HDR mode is on. Also, when fp16 and HDR is on, return scRGB linear textures. BUG=682416 Review-Url: https://codereview.chromium.org/2721893003 Cr-Commit-Position: refs/heads/master@{#454057} Committed: https://chromium.googlesource.com/chromium/src/+/3944b9334aa1e6bd10f2627294f82d3e6b92c549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M media/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 6 chunks +29 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hubbe
3 years, 9 months ago (2017-02-28 23:30:38 UTC) #6
jbauman
lgtm
3 years, 9 months ago (2017-03-01 00:03:00 UTC) #7
ccameron
lgtm as well
3 years, 9 months ago (2017-03-01 20:32:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721893003/1
3 years, 9 months ago (2017-03-01 20:37:36 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:06:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3944b9334aa1e6bd10f2627294f8...

Powered by Google App Engine
This is Rietveld 408576698