Telemetry: Clean up perf profiler unit tests.

Telemetry: Clean up perf profiler unit tests.

Add SetAttribute method to MockObject to avoid setting attributes outside of the
class.
Remove unused variables.

BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270765

[Dominik Grewe, 2014-05-14 11:14:00]

ptal

[dtu, 2014-05-14 23:32:45]

https://chromiumcodereview.appspot.com/272183006/diff/1/tools/telemetry/telem...
File tools/telemetry/telemetry/core/browser.py (right):

https://chromiumcodereview.appspot.com/272183006/diff/1/tools/telemetry/telem...
tools/telemetry/telemetry/core/browser.py:57: def platform_backend(self):
We definitely don't want to expose these APIs publicly. I think it's fine to use
# pylint: disable=W123 annotations in unit tests sometimes.

[Dominik Grewe, 2014-05-15 08:55:43]

https://codereview.chromium.org/272183006/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/browser.py (right):

https://codereview.chromium.org/272183006/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/browser.py:57: def platform_backend(self):
On 2014/05/14 23:32:45, dtu wrote:
> We definitely don't want to expose these APIs publicly. I think it's fine to
use
> # pylint: disable=W123 annotations in unit tests sometimes.

Done.

[dtu, 2014-05-15 17:34:59]

Thanks! lgtm

[dtu, 2014-05-15 17:55:20]

On 2014/05/15 17:34:59, dtu wrote:
> Thanks! lgtm

I need to land an emergency change, so I'm going to land this manually.

[dtu, 2014-05-15 18:50:55]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-05-15 18:51:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dominikg@chromium.org/272183006/20001

[commit-bot: I haz the power, 2014-05-15 19:04:27]

Change committed as 270765