tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py - Issue 272183006: Telemetry: Clean up perf profiler unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

Issue 272183006: Telemetry: Clean up perf profiler unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove Browser getters and disable pylint warnings. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

index 5b11f251d4e92fca96c1415f5456f3a277a4e692..afc0a511fe4985de993a2ab9f113ea56fb58bb16 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

@@ -28,7 +28,7 @@ class TestPerfProfiler(unittest.TestCase):

mock_subprocess = simple_mock.MockObject()

mock_subprocess.ExpectCall(

'Popen').WithArgs(simple_mock.DONT_CARE).WillReturn(mock_popen)

- setattr(mock_subprocess, 'PIPE', simple_mock.MockObject())

+ mock_subprocess.SetAttribute('PIPE', simple_mock.MockObject())

real_subprocess = perf_profiler.subprocess

perf_profiler.subprocess = mock_subprocess

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py » ('j') | no next file with comments »