Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2721823002: Update content settings to new vector icon format. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, posciak+watch_chromium.org, chromium-apps-reviews_chromium.org, subresource-filter-reviews_chromium.org, toyoshim+midi_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update content settings to new vector icon format. BUG=626786 Review-Url: https://codereview.chromium.org/2721823002 Cr-Commit-Position: refs/heads/master@{#453514} Committed: https://chromium.googlesource.com/chromium/src/+/eac868b87946406cbcce4633a76fca5e65ab9291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -475 lines) Patch
M chrome/app/vector_icons/BUILD.gn View 5 chunks +8 lines, -0 lines 0 comments Download
A + chrome/app/vector_icons/blocked_badge.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/code.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/image.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/mixed_content.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/my_location.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/subresource_filter_active.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/vector_icons/warning_badge.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/vector_icons/web.icon View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.cc View 11 chunks +33 lines, -43 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 2 chunks +0 lines, -13 lines 0 comments Download
D ui/gfx/vector_icons/blocked_badge.icon View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/gfx/vector_icons/code.icon View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/gfx/vector_icons/cookie.icon View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/gfx/vector_icons/extension.icon View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/gfx/vector_icons/file_download.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/image.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/gfx/vector_icons/midi.icon View 1 chunk +0 lines, -41 lines 0 comments Download
D ui/gfx/vector_icons/mixed_content.icon View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gfx/vector_icons/my_location.icon View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/gfx/vector_icons/protocol_handler.icon View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/gfx/vector_icons/subresource_filter_active.icon View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/vector_icons/videocam.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/gfx/vector_icons/warning_badge.icon View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Evan Stade
3 years, 9 months ago (2017-02-28 04:11:55 UTC) #3
sky
LGTM
3 years, 9 months ago (2017-02-28 05:08:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721823002/1
3 years, 9 months ago (2017-02-28 05:10:42 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 05:37:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eac868b87946406cbcce4633a76f...

Powered by Google App Engine
This is Rietveld 408576698