Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 2721803002: Fix the inability to delete just-downloaded pages from Download Home. (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the inability to delete just-downloaded pages from Download Home. This happens because Offline Page is initially created w/o file path, which becomes known when the OfflinePageDownloadItem is updated in the process of download. We need to update mFilePathsToItemsMap map which is used during deletion to find all the items using the same file path. BUG=696830 Review-Url: https://codereview.chromium.org/2721803002 Cr-Commit-Position: refs/heads/master@{#453719} Committed: https://chromium.googlesource.com/chromium/src/+/335b9f4cc30ccbeeb8c40e3ad6b7435a73af9a6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Dmitry Titov
Hi Theresa, this is another small fix for Offline Pages in Download Home. No test ...
3 years, 9 months ago (2017-02-28 02:05:14 UTC) #5
Theresa
lgtm
3 years, 9 months ago (2017-02-28 21:18:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721803002/1
3 years, 9 months ago (2017-02-28 21:59:46 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:09:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/335b9f4cc30ccbeeb8c40e3ad6b7...

Powered by Google App Engine
This is Rietveld 408576698