Chromium Code Reviews Chromium Code Reviews
Issue 27218005:
rebaseline_server: add --editable and --reload flags (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/| Index: gm/rebaseline_server/static/view.html |
| =================================================================== |
| --- gm/rebaseline_server/static/view.html (revision 11776) |
| +++ gm/rebaseline_server/static/view.html (working copy) |
| @@ -3,7 +3,7 @@ |
| <html ng-app="Loader"> |
| <head> |
| - <title>Current GM Results</title> |
| + <title>GM Results</title> |
| <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"></script> |
| <script src="loader.js"></script> |
| </head> |
| @@ -11,9 +11,6 @@ |
| <body> |
| <div ng-controller="Loader.Controller"> |
| - <!-- TODO(epoger): Add some indication of how old the |
| - expected/actual data is --> |
| - |
| <em> |
| {{loadingMessage}} |
| </em> |
| @@ -24,6 +21,9 @@ |
| WARNING! These results are editable and exported, so any user |
| who can connect to this server over the network can modify them. |
| </div> |
| + <div ng-hide="!(header.timeUpdated)"> |
| + Results current as of {{localTimeString(header.timeUpdated)}} |
| + </div> |
| <table border="1"> |
| <tr> |
| <th colspan="2"> |
| @@ -83,22 +83,42 @@ |
| </table> |
| <p> |
| - TODO(epoger): Add ability to filter builder and test names |
| - (using a free-form text field, with partial string match) |
| - <br> |
| - TODO(epoger): Add more columns, such as pixel diffs, notes/bugs, |
| - ignoreFailure boolean |
| - <br> |
| - TODO(epoger): Improve the column sorting, as per |
| - <a href="http://jsfiddle.net/vojtajina/js64b/14/"> |
| - http://jsfiddle.net/vojtajina/js64b/14/ |
| - </a> |
| - <br> |
| - TODO(epoger): Right now, if you change which column is used to |
| - sort the data, the column widths may fluctuate based on the |
| - longest string <i>currently visible</i> within the top {{displayLimit}} |
| - results. Can we fix the column widths to be wide enough to hold |
| - any result, even the currently hidden results? |
| + TODO(epoger): |
|
epoger
2013/10/15 18:31:21
Incidental change: display UI TODOs within a colla
|
| + <input type="radio" name="showTodosRadio" value="true" |
|
jcgregorio
2013/10/15 18:48:57
Can you make this a checkbox?
epoger
2013/10/15 19:25:00
Done.
|
| + ng-checked="showTodos == true" |
| + ng-click="showTodos = true"> |
| + show |
| + <input type="radio" name="showTodosRadio" value="false" |
| + ng-checked="showTodos == false" |
| + ng-click="showTodos = false"> |
| + hide |
| + <ul ng-hide="!showTodos"> |
| + <li> |
| + Implement editing of results (we have added the --editable |
| + flag to the server, but it's not fully implemented yet). |
| + </li><li> |
| + If server was run with --reload flag, automatically check for |
| + new results and tell the user when new results are available |
| + (the user can reload the page if he wants to see them). |
| + </li><li> |
| + Add ability to filter builder and test names |
| + (using a free-form text field, with partial string match) |
| + </li><li> |
| + Add more columns, such as pixel diffs, notes/bugs, |
| + ignoreFailure boolean |
| + </li><li> |
| + Improve the column sorting, as per |
| + <a href="http://jsfiddle.net/vojtajina/js64b/14/"> |
| + http://jsfiddle.net/vojtajina/js64b/14/ |
| + </a> |
| + </li><li> |
| + Right now, if you change which column is used to |
| + sort the data, the column widths may fluctuate based on the |
| + longest string <i>currently visible</i> within the top {{displayLimit}} |
| + results. Can we fix the column widths to be wide enough to hold |
| + any result, even the currently hidden results? |
| + </li> |
| + </ul> |
| <p> |
| Found {{filteredTestData.length}} matches, and displaying the first |
| {{displayLimit}}: <br> |
