Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: gm/rebaseline_server/static/view.html

Issue 27218005: rebaseline_server: add --editable and --reload flags (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« gm/rebaseline_server/static/loader.js ('K') | « gm/rebaseline_server/static/loader.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader"> 3 <html ng-app="Loader">
4 4
5 <head> 5 <head>
6 <title>Current GM Results</title> 6 <title>GM Results</title>
7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script> 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script>
8 <script src="loader.js"></script> 8 <script src="loader.js"></script>
9 </head> 9 </head>
10 10
11 <body> 11 <body>
12 <div ng-controller="Loader.Controller"> 12 <div ng-controller="Loader.Controller">
13 13
14 <!-- TODO(epoger): Add some indication of how old the
15 expected/actual data is -->
16
17 <em> 14 <em>
18 {{loadingMessage}} 15 {{loadingMessage}}
19 </em> 16 </em>
20 17
21 <div ng-hide="!categories"> 18 <div ng-hide="!categories">
22 <div ng-hide="!(header.isEditable && header.isExported)" 19 <div ng-hide="!(header.isEditable && header.isExported)"
23 style="background-color:#ffbb00"> 20 style="background-color:#ffbb00">
24 WARNING! These results are editable and exported, so any user 21 WARNING! These results are editable and exported, so any user
25 who can connect to this server over the network can modify them. 22 who can connect to this server over the network can modify them.
26 </div> 23 </div>
24 <div ng-hide="!(header.timeUpdated)">
25 Results current as of {{localTimeString(header.timeUpdated)}}
26 </div>
27 <table border="1"> 27 <table border="1">
28 <tr> 28 <tr>
29 <th colspan="2"> 29 <th colspan="2">
30 Filters 30 Filters
31 </th> 31 </th>
32 <th> 32 <th>
33 Settings 33 Settings
34 </th> 34 </th>
35 </tr> 35 </tr>
36 <tr valign="top"> 36 <tr valign="top">
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 ng-click="updateResults()" 76 ng-click="updateResults()"
77 ng-disabled="!areUpdatesPending"> 77 ng-disabled="!areUpdatesPending">
78 Update Results 78 Update Results
79 </button> 79 </button>
80 </td></tr> 80 </td></tr>
81 </tr></table></td> 81 </tr></table></td>
82 </tr> 82 </tr>
83 </table> 83 </table>
84 84
85 <p> 85 <p>
86 TODO(epoger): Add ability to filter builder and test names 86 TODO(epoger):
epoger 2013/10/15 18:31:21 Incidental change: display UI TODOs within a colla
87 (using a free-form text field, with partial string match) 87 <input type="radio" name="showTodosRadio" value="true"
jcgregorio 2013/10/15 18:48:57 Can you make this a checkbox?
epoger 2013/10/15 19:25:00 Done.
88 <br> 88 ng-checked="showTodos == true"
89 TODO(epoger): Add more columns, such as pixel diffs, notes/bugs, 89 ng-click="showTodos = true">
90 ignoreFailure boolean 90 show
91 <br> 91 <input type="radio" name="showTodosRadio" value="false"
92 TODO(epoger): Improve the column sorting, as per 92 ng-checked="showTodos == false"
93 <a href="http://jsfiddle.net/vojtajina/js64b/14/"> 93 ng-click="showTodos = false">
94 http://jsfiddle.net/vojtajina/js64b/14/ 94 hide
95 </a> 95 <ul ng-hide="!showTodos">
96 <br> 96 <li>
97 TODO(epoger): Right now, if you change which column is used to 97 Implement editing of results (we have added the --editable
98 sort the data, the column widths may fluctuate based on the 98 flag to the server, but it&#39;s not fully implemented yet).
99 longest string <i>currently visible</i> within the top {{displayLimit}} 99 </li><li>
100 results. Can we fix the column widths to be wide enough to hold 100 If server was run with --reload flag, automatically check for
101 any result, even the currently hidden results? 101 new results and tell the user when new results are available
102 (the user can reload the page if he wants to see them).
103 </li><li>
104 Add ability to filter builder and test names
105 (using a free-form text field, with partial string match)
106 </li><li>
107 Add more columns, such as pixel diffs, notes/bugs,
108 ignoreFailure boolean
109 </li><li>
110 Improve the column sorting, as per
111 <a href="http://jsfiddle.net/vojtajina/js64b/14/">
112 http://jsfiddle.net/vojtajina/js64b/14/
113 </a>
114 </li><li>
115 Right now, if you change which column is used to
116 sort the data, the column widths may fluctuate based on the
117 longest string <i>currently visible</i> within the top {{displayLimit} }
118 results. Can we fix the column widths to be wide enough to hold
119 any result, even the currently hidden results?
120 </li>
121 </ul>
102 <p> 122 <p>
103 Found {{filteredTestData.length}} matches, and displaying the first 123 Found {{filteredTestData.length}} matches, and displaying the first
104 {{displayLimit}}: <br> 124 {{displayLimit}}: <br>
105 <!-- TODO(epoger): If (displayLimit <= filteredTestData.length), 125 <!-- TODO(epoger): If (displayLimit <= filteredTestData.length),
106 modify this message to indicate that all results are shown. --> 126 modify this message to indicate that all results are shown. -->
107 (click on the column header radio buttons to re-sort by that column) 127 (click on the column header radio buttons to re-sort by that column)
108 <br> 128 <br>
109 <table border="1"> 129 <table border="1">
110 <tr> 130 <tr>
111 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf ig']"> 131 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf ig']">
(...skipping 14 matching lines...) Expand all
126 </th> 146 </th>
127 <th> 147 <th>
128 <input type="radio" 148 <input type="radio"
129 name="sortColumnRadio" 149 name="sortColumnRadio"
130 value="actualHashDigest" 150 value="actualHashDigest"
131 ng-checked="(sortColumn == 'actualHashDigest')" 151 ng-checked="(sortColumn == 'actualHashDigest')"
132 ng-click="sortResultsBy('actualHashDigest')"> 152 ng-click="sortResultsBy('actualHashDigest')">
133 actual image 153 actual image
134 </th> 154 </th>
135 <th ng-hide="!header.isEditable"> 155 <th ng-hide="!header.isEditable">
136 <!-- item-selection checkbox column --> 156 <!-- item-selection checkbox column -->
epoger 2013/10/15 19:25:00 What that means is that the --editable functionali
137 {{selectedItems}} <!-- TODO(epoger): temporary debug output --> 157 {{selectedItems}} <!-- TODO(epoger): temporary debug output -->
jcgregorio 2013/10/15 18:48:57 Maybe put this kind of debugging info in a "debug"
epoger 2013/10/15 19:25:00 Done.
138 </th> 158 </th>
139 </tr> 159 </tr>
140 <tr ng-repeat="result in limitedTestData"> 160 <tr ng-repeat="result in limitedTestData">
141 <td>{{result.resultType}}</td> 161 <td>{{result.resultType}}</td>
142 <td>{{result.builder}}</td> 162 <td>{{result.builder}}</td>
143 <td>{{result.test}}</td> 163 <td>{{result.test}}</td>
144 <td>{{result.config}}</td> 164 <td>{{result.config}}</td>
145 <td> 165 <td>
146 <a target="_blank" href="http://chromium-skia-gm.commondatastorage.g oogleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.expectedHa shDigest}}.png"> 166 <a target="_blank" href="http://chromium-skia-gm.commondatastorage.g oogleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.expectedHa shDigest}}.png">
147 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.e xpectedHashDigest}}.png"/> 167 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.e xpectedHashDigest}}.png"/>
(...skipping 18 matching lines...) Expand all
166 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and 186 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and
167 issues list) from 187 issues list) from
168 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json 188 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json
169 ? I tried importing the 189 ? I tried importing the
170 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using 190 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using
171 that to do so, but I got Access-Control-Allow-Origin errors. 191 that to do so, but I got Access-Control-Allow-Origin errors.
172 --> 192 -->
173 193
174 </body> 194 </body>
175 </html> 195 </html>
OLDNEW
« gm/rebaseline_server/static/loader.js ('K') | « gm/rebaseline_server/static/loader.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698