rebaseline_server: add --editable and --reload flags

rebaseline_server: add --editable and --reload flags

This is a variation on the --browseonly flag we came up with in
https://codereview.chromium.org/24274003/#msg6 .

The long-lived "view only" server will probably be run like this:
server.py --export --reload 300

And when rebaselining you'll run your own server like this:
server.py --editable

(SkipBuildbotRuns)

R=jcgregorio@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11788

[epoger, 2013-10-15 18:31:21]

[Joe is main reviewer; Brian, please review the UI]

Ready for review at patchset 1, and two copies are running for your evaluation:

$ python server.py --export --port 7777 --editable
http://wpgntat-ubiq141.hot.corp.google.com:7777

$ python server.py --export --port 8888 --expectations-dir .gm-expectations
--reload 60
http://wpgntat-ubiq141.hot.corp.google.com:8888

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.p...
gm/rebaseline_server/server.py:211: with _SERVER.results_lock:
_SERVER.results_lock makes sure that the results are not updated while they are
being served out.

If there are multiple readers, they will lock each other out as well... but I
don't think that's a big deal--the lock should be released pretty quickly.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.p...
gm/rebaseline_server/server.py:228: # this ensures that the edits were made to a
particular dataset.
We will also use this hash to determine when there are new results to display on
the client side.  (The client will periodically download this hash; when it
changes, the client will tell the user "reload to see new data".)

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.p...
gm/rebaseline_server/server.py:321: help=('TODO(epoger): NOT YET IMPLEMENTED.  '
For now, setting this flag enables the nascent editing UI on the client side.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:36: $window.document.title = "Loading GM
Results...";
incidental change: Change the document title based on whether loading has
completed, so that you can tell when it's done just by looking at the browser
tab.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:86: TODO(epoger):
Incidental change: display UI TODOs within a collapsable element, so that users
can easily see them or ignore them as they choose.

[bsalomon, 2013-10-15 18:41:11]

What does this mean (after I select both images)?

{"0":true,"521":true}

[jcgregorio, 2013-10-15 18:48:57]

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.p...
gm/rebaseline_server/server.py:120: # --reload argument; otherwise, we expect
the user to maintain his own
his/her own expectations as they see fit.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:64: $window.document.title = "Current GM
Results";
$scope.title = "Current...

And then update the HTML template to use {{title}}.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:87: <input type="radio"
name="showTodosRadio" value="true"
Can you make this a checkbox?

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:157: {{selectedItems}}  <!-- TODO(epoger):
temporary debug output -->
Maybe put this kind of debugging info in a "debug" div that appears in the
showTodosRadio above?

[epoger, 2013-10-15 19:25:00]

PTAL

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/server.p...
gm/rebaseline_server/server.py:120: # --reload argument; otherwise, we expect
the user to maintain his own
On 2013/10/15 18:48:57, jcgregorio wrote:
> his/her own expectations as they see fit.

I find that construction really awkward, so I changed it to "her".

See http://language.gov.uk/buganizer/1 ("add gender-neutral pronoun")

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:64: $window.document.title = "Current GM
Results";
On 2013/10/15 18:48:57, jcgregorio wrote:
> $scope.title = "Current...
> 
> And then update the HTML template to use {{title}}.

That doesn't work without some additional changes... from
http://stackoverflow.com/questions/12506329/how-to-dynamically-change-header-...
:

1. In view.html, we would have to bind the controller at the <html> level rather
than the <div> level (line 12).

2. Even with that change, we would have to use ng-bind instead of
curly-brackets, or else the curly-brackets would flash up there at page load.

I can make those two changes if you like... my question is, is that preferable
to the way I have it here, which seems simpler to me?  Please let me know what
you think.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:87: <input type="radio"
name="showTodosRadio" value="true"
On 2013/10/15 18:48:57, jcgregorio wrote:
> Can you make this a checkbox?

Done.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:156: <!-- item-selection checkbox column
-->
On 2013/10/15 18:41:11, bsalomon wrote:
> What does this mean (after I select both images)?
> 
> {"0":true,"521":true}

What that means is that the --editable functionality isn't fully working yet.
:-)

What you're seeing there is the debug output I put in place for now, showing the
data structure of rows that have been selected for action.  In the next CL, I
will add the actions: Hide and Approve, for starters.

Per Joe's comment below, I have moved this mysterious output into the TODOs
section, where it can be hidden from impressionable eyes.

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/v...
gm/rebaseline_server/static/view.html:157: {{selectedItems}}  <!-- TODO(epoger):
temporary debug output -->
On 2013/10/15 18:48:57, jcgregorio wrote:
> Maybe put this kind of debugging info in a "debug" div that appears in the
> showTodosRadio above?

Done.

[jcgregorio, 2013-10-15 19:38:32]

LGTM

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/27218005/diff/1/gm/rebaseline_server/static/l...
gm/rebaseline_server/static/loader.js:64: $window.document.title = "Current GM
Results";
On 2013/10/15 19:25:00, epoger wrote:
> That doesn't work without some additional changes... from
>
http://stackoverflow.com/questions/12506329/how-to-dynamically-change-header-...
> :
> 
> 1. In view.html, we would have to bind the controller at the <html> level
rather
> than the <div> level (line 12).
> 
> 2. Even with that change, we would have to use ng-bind instead of
> curly-brackets, or else the curly-brackets would flash up there at page load.
> 
> I can make those two changes if you like... my question is, is that preferable
> to the way I have it here, which seems simpler to me?  Please let me know what
> you think.

Urg, I wish that wasn't so complicated, leave it as is.

I do wish we could use state.title, that way you can look at the HTML page and
see everything that's going to change, but now looking there you have no idea
the title could change.

[epoger, 2013-10-15 20:10:15]

> I do wish we could use state.title, that way you can look at the HTML page and
> see everything that's going to change, but now looking there you have no idea
> the title could change.

I agree, and I hadn't thought of that.  So I tried the change, and it wasn't as
bad as I feared.  For one thing, it let me get rid of an unused <div> that had
been bugging me for a while.

[epoger, 2013-10-15 20:10:37]

Committed patchset #3 manually as r11788 (presubmit successful).