[Mac] Remove dead code from bookmark bar controller

[Mac] Remove dead code from bookmark bar controller

Not called anywhere but the test

BUG=648560
Review-Url: https://codereview.chromium.org/2721773003
Cr-Commit-Position: refs/heads/master@{#453943}
Committed: https://chromium.googlesource.com/chromium/src/+/c6bc7e12a0d16beb801651718a1e4bd7c2d376b5

[lgrey, 2017-02-28 17:11:50]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 17:12:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgrey, 2017-02-28 18:50:55]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 18:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 19:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:19:00]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-02-28 19:19:43]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2017-02-28 19:19:44]

PTAL :)

[Elly Fong-Jones, 2017-02-28 19:28:56]

On 2017/02/28 19:19:44, lgrey wrote:
> PTAL :)

Was this test providing coverage of anything other than the removed code?

[lgrey, 2017-02-28 19:41:23]

On 2017/02/28 19:28:56, Elly Fong-Jones wrote:
> On 2017/02/28 19:19:44, lgrey wrote:
> > PTAL :)
> 
> Was this test providing coverage of anything other than the removed code?

Not really AFAICT. You could make a case that it tests |nodeIdFromMenuTag:| but
this is covered in a more focused test
(https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/bookmarks/bookma...)

[Elly Fong-Jones, 2017-03-01 16:04:07]

lgtm

[lgrey, 2017-03-01 16:04:45]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-03-01 16:04:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 16:08:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488384285800810,
"parent_rev": "b426395b49bd51921db31b0144415bf613d7566f", "commit_rev":
"c6bc7e12a0d16beb801651718a1e4bd7c2d376b5"}

[commit-bot: I haz the power, 2017-03-01 16:09:28]

Description was changed from

==========
[Mac] Remove dead code from bookmark bar controller

Not called anywhere but the test

BUG=648560
==========

to

==========
[Mac] Remove dead code from bookmark bar controller

Not called anywhere but the test

BUG=648560

Review-Url: https://codereview.chromium.org/2721773003
Cr-Commit-Position: refs/heads/master@{#453943}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6bc7e12a0d16beb801651718a1e...
==========

[commit-bot: I haz the power, 2017-03-01 16:09:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c6bc7e12a0d16beb801651718a1e...