Remove unused utility methods.

Remove unused utility methods.

These methods are error prone in that they make it easy to ignore
invalid results by ignoring the clipped flag.  They are not used
in the active chrome code.  This should be just clean-up.

These came to light in investigating bug 626095, but this does
not address it, so it isn't useful to link them.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2721743003
Cr-Commit-Position: refs/heads/master@{#457834}
Committed: https://chromium.googlesource.com/chromium/src/+/ca9b8202f0677050363bb133554e0e7149365645

[Peter Mayo, 2017-02-28 17:23:24]

Description was changed from

==========
Remove unused utility methods.

These methods are error prone in that they make it easy to ignore
invalid results by ignoring the clipped flag.  They are not used
in the active chrome code.  This should be just clean-up.

These came to light in investigating bug 626095, but this does
not address it, so it isn't useful to link them.

BUG=None
==========

to

==========
Remove unused utility methods.

These methods are error prone in that they make it easy to ignore
invalid results by ignoring the clipped flag.  They are not used
in the active chrome code.  This should be just clean-up.

These came to light in investigating bug 626095, but this does
not address it, so it isn't useful to link them.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Peter Mayo, 2017-03-14 18:11:20]

The CQ bit was checked by petermayo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 18:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Mayo, 2017-03-14 18:12:18]

petermayo@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:37:22]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-03-14 20:14:11]

LGTM

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:2969: static bool
projection_clips(const gfx::Transform& t, const gfx::RectF& r) {
nit: ProjectionClips

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:2970: gfx::Transform
inv_t(Inverse(t));
nit: inverted (or some not-shortened word/s)

[Peter Mayo, 2017-03-17 00:35:54]

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:2969: static bool
projection_clips(const gfx::Transform& t, const gfx::RectF& r) {
On 2017/03/14 20:14:11, danakj wrote:
> nit: ProjectionClips

Done.

https://codereview.chromium.org/2721743003/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:2970: gfx::Transform
inv_t(Inverse(t));
On 2017/03/14 20:14:11, danakj wrote:
> nit: inverted (or some not-shortened word/s)

Done.

[Peter Mayo, 2017-03-17 15:46:46]

More renames,  PTAL

[danakj, 2017-03-17 16:16:10]

LGTM!

[Peter Mayo, 2017-03-17 17:15:41]

The CQ bit was checked by petermayo@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:54:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489770941326810,
"parent_rev": "937ebc1a2de7ac71ec1de4c6bb1ed7a6331e4683", "commit_rev":
"ca9b8202f0677050363bb133554e0e7149365645"}

[commit-bot: I haz the power, 2017-03-17 18:55:32]

Description was changed from

==========
Remove unused utility methods.

These methods are error prone in that they make it easy to ignore
invalid results by ignoring the clipped flag.  They are not used
in the active chrome code.  This should be just clean-up.

These came to light in investigating bug 626095, but this does
not address it, so it isn't useful to link them.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove unused utility methods.

These methods are error prone in that they make it easy to ignore
invalid results by ignoring the clipped flag.  They are not used
in the active chrome code.  This should be just clean-up.

These came to light in investigating bug 626095, but this does
not address it, so it isn't useful to link them.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2721743003
Cr-Commit-Position: refs/heads/master@{#457834}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca9b8202f0677050363bb133554e...
==========

[commit-bot: I haz the power, 2017-03-17 18:55:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca9b8202f0677050363bb133554e...