Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2721733003: Handle the dual microphones and dual cameras cases. Activate the proper microphone when user activa… (Closed)

Created:
3 years, 9 months ago by jennyz
Modified:
3 years, 9 months ago
Reviewers:
shenghao, hychao
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle the dual microphones and dual cameras cases. Activate the proper microphone when user activates the front or rear camera on basking devices. BUG=698327 TEST=See the feature spec document in the bug. TBR=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2721733003 Cr-Commit-Position: refs/heads/master@{#454933} Committed: https://chromium.googlesource.com/chromium/src/+/fbaa3e6092a9d8d08a91cd71fdd104dca8df2cfc

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix build issue. #

Patch Set 4 : Fix test issue. #

Total comments: 30

Patch Set 5 : Address the code review comments. #

Patch Set 6 : Nit: log only the invalid camera facing mode value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -68 lines) Patch
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 2 chunks +35 lines, -5 lines 0 comments Download
M chromeos/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/audio/audio_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/audio/audio_device.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 4 chunks +35 lines, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 2 3 4 5 19 chunks +220 lines, -62 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 1 2 3 4 8 chunks +249 lines, -1 line 0 comments Download
M media/base/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
jennyz
3 years, 9 months ago (2017-02-28 18:15:43 UTC) #3
jennyz
dalecurtis@, please review base/media. shenghao@ and hychao@, please review everything.
3 years, 9 months ago (2017-02-28 21:42:27 UTC) #4
jennyz
3 years, 9 months ago (2017-03-01 00:39:16 UTC) #6
shenghao
On 2017/03/01 00:39:16, jennyz wrote: Please add "TEST=" in the CL description to explain how ...
3 years, 9 months ago (2017-03-01 10:41:47 UTC) #7
shenghao
https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode141 chromeos/audio/cras_audio_handler.cc:141: NOTREACHED(); I am not 100% sure but I think ...
3 years, 9 months ago (2017-03-01 11:25:55 UTC) #8
shenghao
https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode177 chromeos/audio/cras_audio_handler.cc:177: SwitchToDevice(*GetDeviceByType(AUDIO_TYPE_FRONT_MIC), true, activate_by); On 2017/03/01 11:25:55, shenghao wrote: > ...
3 years, 9 months ago (2017-03-01 11:27:54 UTC) #9
jennyz
https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode141 chromeos/audio/cras_audio_handler.cc:141: NOTREACHED(); On 2017/03/01 11:25:55, shenghao wrote: > I am ...
3 years, 9 months ago (2017-03-02 17:31:41 UTC) #11
shenghao
On 2017/03/02 17:31:41, jennyz wrote: > https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc > File chromeos/audio/cras_audio_handler.cc (right): > > https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode141 > ...
3 years, 9 months ago (2017-03-03 03:45:09 UTC) #12
shenghao
https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode141 chromeos/audio/cras_audio_handler.cc:141: NOTREACHED(); On 2017/03/02 17:31:40, jennyz wrote: > On 2017/03/01 ...
3 years, 9 months ago (2017-03-03 03:45:21 UTC) #13
jennyz
https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc File chromeos/audio/cras_audio_handler.cc (right): https://codereview.chromium.org/2721733003/diff/60001/chromeos/audio/cras_audio_handler.cc#newcode141 chromeos/audio/cras_audio_handler.cc:141: NOTREACHED(); On 2017/03/03 03:45:21, shenghao wrote: > On 2017/03/02 ...
3 years, 9 months ago (2017-03-03 19:35:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721733003/100001
3 years, 9 months ago (2017-03-03 19:35:56 UTC) #17
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-03 19:35:57 UTC) #19
jennyz
hychao@, would you please take a look at this cl? shenghao already LGTMed it. But ...
3 years, 9 months ago (2017-03-03 19:50:53 UTC) #21
hychao
lgtm
3 years, 9 months ago (2017-03-06 10:08:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721733003/100001
3 years, 9 months ago (2017-03-06 18:25:25 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:14:53 UTC) #28
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fbaa3e6092a9d8d08a91cd71fdd1...

Powered by Google App Engine
This is Rietveld 408576698