Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2721723002: DevTools: Restore show panel commands in CommandMenu (Closed)

Created:
3 years, 9 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Restore show panel commands in CommandMenu The CommandMenu was querying the runtime for UI.Panel, but panel extensions are defined as "view" with a location of panel. BUG=none Review-Url: https://codereview.chromium.org/2721723002 Cr-Commit-Position: refs/heads/master@{#453798} Committed: https://chromium.googlesource.com/chromium/src/+/e5911968024e82a74a71709a2744aae77dcb1b8c

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
A third_party/WebKit/LayoutTests/inspector/quick-open/command-menu.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/quick-open/command-menu-expected.txt View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js View 2 chunks +9 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
einbinder
ptal
3 years, 9 months ago (2017-02-27 20:44:01 UTC) #2
einbinder
added a test
3 years, 9 months ago (2017-02-28 01:33:26 UTC) #3
dgozman
lgtm
3 years, 9 months ago (2017-02-28 19:22:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721723002/20001
3 years, 9 months ago (2017-02-28 22:46:51 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 02:50:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5911968024e82a74a71709a2744...

Powered by Google App Engine
This is Rietveld 408576698