Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2721673002: Fix isolation for VR tests (Closed)

Created:
3 years, 9 months ago by bsheedy
Modified:
3 years, 9 months ago
Reviewers:
nyquist, jbudorick
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix isolation for VR tests One of the data dependencies is a directory, which apparently needs to end in a / to work properly with swarming. BUG= Review-Url: https://codereview.chromium.org/2721673002 Cr-Commit-Position: refs/heads/master@{#453635} Committed: https://chromium.googlesource.com/chromium/src/+/7280d1ca595f25bafc9577802f9d3c4430c9f7e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
bsheedy
PTAL
3 years, 9 months ago (2017-02-27 19:00:54 UTC) #2
jbudorick
drive-by lgtm
3 years, 9 months ago (2017-02-27 22:56:43 UTC) #4
bsheedy
On 2017/02/27 22:56:43, jbudorick wrote: > drive-by lgtm Thanks - it still doesn't think it's ...
3 years, 9 months ago (2017-02-27 22:59:36 UTC) #5
jbudorick
On 2017/02/27 22:59:36, bsheedy wrote: > On 2017/02/27 22:56:43, jbudorick wrote: > > drive-by lgtm ...
3 years, 9 months ago (2017-02-27 23:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721673002/1
3 years, 9 months ago (2017-02-27 23:00:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/373991)
3 years, 9 months ago (2017-02-27 23:13:31 UTC) #10
nyquist
lgtm
3 years, 9 months ago (2017-02-28 02:54:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721673002/1
3 years, 9 months ago (2017-02-28 17:09:14 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 17:46:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7280d1ca595f25bafc9577802f9d...

Powered by Google App Engine
This is Rietveld 408576698