Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js

Issue 2721663005: [DevTools] Access cpu profiler only when JS capability is present. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
index 27fba039c99e2173483ca04bdb9b00b125f71ccb..2d99539041c5c46b17933c4828874ac1d0853296 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
@@ -79,11 +79,14 @@ Coverage.CoverageView = class extends UI.VBox {
if (!mainTarget)
return;
var cssModel = mainTarget.model(SDK.CSSModel);
- if (!cssModel)
+ var cpuProfilerModel = mainTarget.model(SDK.CPUProfilerModel);
+ if (!cssModel && !cpuProfilerModel)
return;
this._toggleRecordAction.setToggled(true);
- cssModel.startRuleUsageTracking();
- mainTarget.profilerAgent().startPreciseCoverage();
+ if (cssModel)
+ cssModel.startRuleUsageTracking();
+ if (cpuProfilerModel)
+ cpuProfilerModel.startPreciseCoverage();
this._progressElement.textContent = Common.UIString('Recording...');
}
@@ -140,11 +143,11 @@ Coverage.CoverageView = class extends UI.VBox {
*/
async _stopJSCoverage() {
var mainTarget = SDK.targetManager.mainTarget();
- var profilerAgent = mainTarget && mainTarget.profilerAgent();
- if (!profilerAgent)
+ var cpuProfilerModel = mainTarget ? mainTarget.model(SDK.CPUProfilerModel) : null;
+ if (!cpuProfilerModel)
return [];
- var coveragePromise = profilerAgent.takePreciseCoverage((error, result) => error ? [] : result);
- profilerAgent.stopPreciseCoverage();
+ var coveragePromise = cpuProfilerModel.takePreciseCoverage();
+ cpuProfilerModel.stopPreciseCoverage();
var rawCoverageData = await coveragePromise;
return Coverage.CoverageView._processJSCoverage(
/** @type !SDK.DebuggerModel */ (SDK.DebuggerModel.fromTarget(mainTarget)), rawCoverageData);

Powered by Google App Engine
This is Rietveld 408576698