Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2721633005: Fix zero channel count being returned for unknown macOS layouts. (Closed)

Created:
3 years, 9 months ago by DaleCurtis
Modified:
3 years, 9 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix zero channel count being returned for unknown macOS layouts. BUG=671308 TEST=none, based on user logs. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2721633005 Cr-Commit-Position: refs/heads/master@{#453510} Committed: https://chromium.googlesource.com/chromium/src/+/408897d8dc0510887278a1f4210d51ba64cf898e

Patch Set 1 #

Patch Set 2 : Zero intialize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M media/audio/mac/audio_manager_mac.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
DaleCurtis
3 years, 9 months ago (2017-02-27 22:52:32 UTC) #3
chcunningham
lgtm
3 years, 9 months ago (2017-02-28 02:41:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721633005/20001
3 years, 9 months ago (2017-02-28 05:07:21 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 05:14:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/408897d8dc0510887278a1f4210d...

Powered by Google App Engine
This is Rietveld 408576698