Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc

Issue 2721613003: [LayoutNG] Move remaining ng_units structs to their own files (Closed)
Patch Set: Don't export NGBoxStrut for now Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units_test.cc b/third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc
similarity index 71%
rename from third_party/WebKit/Source/core/layout/ng/ng_units_test.cc
rename to third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc
index cd9b9318b3fbb81ef1e469b3ed1c429ddc5ddcd7..7beacbd6ce6afcfd6cf01477a1d7d5a43de4f5ed 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_units_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/geometry/ng_box_strut_test.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "core/layout/ng/ng_units.h"
+#include "core/layout/ng/geometry/ng_box_strut.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -12,7 +12,7 @@ namespace {
// Ideally, this would be tested by NGBoxStrut::ConvertToPhysical, but
// this has not been implemented yet.
-TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) {
+TEST(NGGeometryUnitsTest, ConvertPhysicalStrutToLogical) {
LayoutUnit left{5}, right{10}, top{15}, bottom{20};
NGPhysicalBoxStrut physical{left, right, top, bottom};
@@ -43,22 +43,6 @@ TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) {
EXPECT_EQ(right, logical.block_start);
}
-TEST(NGUnitsTest, ShrinkToFit) {
- MinAndMaxContentSizes sizes;
-
- sizes.min_content = LayoutUnit(100);
- sizes.max_content = LayoutUnit(200);
- EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(300)));
-
- sizes.min_content = LayoutUnit(100);
- sizes.max_content = LayoutUnit(300);
- EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(200)));
-
- sizes.min_content = LayoutUnit(200);
- sizes.max_content = LayoutUnit(300);
- EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(100)));
-}
-
} // namespace
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698