chrome://ntp-tiles-internals: hide when incognito

chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622, 696471, 681774
Review-Url: https://codereview.chromium.org/2721603002
Cr-Commit-Position: refs/heads/master@{#453220}
Committed: https://chromium.googlesource.com/chromium/src/+/d6336797781587abf6c3fa648d034315714d1134

[sfiera, 2017-02-27 14:52:05]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 14:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-02-27 14:52:34]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2017-02-27 14:52:35]

Fixes a minor crasher.

[Marc Treib, 2017-02-27 15:04:54]

LGTM, but I don't see how this fixes a crash?

I'd add the improved-but-not-fixed bug to the BUG= list.

[sfiera, 2017-02-27 15:14:29]

Description was changed from

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

This improves 681774 but doesn't quite fix it.

BUG=682622,696471
==========

to

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash.

BUG=682622,696471,681774
==========

[sfiera, 2017-02-27 15:14:43]

On 2017/02/27 15:04:54, Marc Treib wrote:
> LGTM, but I don't see how this fixes a crash?

Description updated.

> I'd add the improved-but-not-fixed bug to the BUG= list.

Done.

[sfiera, 2017-02-27 15:15:12]

Description was changed from

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash.

BUG=682622,696471,681774
==========

to

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622,696471,681774
==========

[commit-bot: I haz the power, 2017-02-27 15:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:32:53]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-02-27 15:39:20]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 15:44:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488209960059670, "parent_rev":
"ef3010cf1291da1c3eb9bbdd6ebd82c6d65f675c", "commit_rev":
"d6336797781587abf6c3fa648d034315714d1134"}

[commit-bot: I haz the power, 2017-02-27 15:44:50]

Description was changed from

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622,696471,681774
==========

to

==========
chrome://ntp-tiles-internals: hide when incognito

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622,696471,681774

Review-Url: https://codereview.chromium.org/2721603002
Cr-Commit-Position: refs/heads/master@{#453220}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6336797781587abf6c3fa648d03...
==========

[commit-bot: I haz the power, 2017-02-27 15:44:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6336797781587abf6c3fa648d03...