Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: ios/web/web_state/http_auth_inttest.mm

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/http_auth_inttest.mm
diff --git a/ios/web/web_state/http_auth_inttest.mm b/ios/web/web_state/http_auth_inttest.mm
index 348460b628d7021b46656a10c5a3524f884fdc58..41bbbd352b4340dfd7c69616f46a06bfe72ab553 100644
--- a/ios/web/web_state/http_auth_inttest.mm
+++ b/ios/web/web_state/http_auth_inttest.mm
@@ -38,7 +38,7 @@ class HttpAuthTest : public WebIntTest {
// Authenticates and waits until the page finishes loading.
void Authenticate(NSString* username, NSString* password) {
ASSERT_TRUE(web_state()->IsLoading());
- auto auth_request = web_state_delegate_.last_authentication_request();
+ auto* auth_request = web_state_delegate_.last_authentication_request();
auth_request->auth_callback.Run(username, password);
base::test::ios::WaitUntilCondition(^bool {
return !web_state()->IsLoading();
@@ -55,7 +55,7 @@ TEST_F(HttpAuthTest, SuccessfullBasicAuth) {
LoadUrlWithAuthChallenge(url);
// Verify that callback receives correct WebState.
- auto auth_request = web_state_delegate_.last_authentication_request();
+ auto* auth_request = web_state_delegate_.last_authentication_request();
EXPECT_EQ(web_state(), auth_request->web_state);
// Verify that callback receives correctly configured protection space.
@@ -88,7 +88,7 @@ TEST_F(HttpAuthTest, UnsucessfulBasicAuth) {
LoadUrlWithAuthChallenge(url);
// Make sure that incorrect credentials request authentication again.
- auto auth_request = web_state_delegate_.last_authentication_request();
+ auto* auth_request = web_state_delegate_.last_authentication_request();
auth_request->auth_callback.Run(@"gooduser", @"goodpass");
WaitForOnAuthRequiredCallback();

Powered by Google App Engine
This is Rietveld 408576698