chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc - Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc ('k') | chrome/browser/android/vr_shell/vr_shell_gl.cc » ('j') | chrome/browser/android/vr_shell/vr_shell_gl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

index d7ef68da8e7b52ea94767a452fff64b193746b81..91afe48a0ecb38eec264cb7af64888e5cefa8530 100644

--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

@@ -213,7 +213,7 @@ void ToJavaOfflinePageDownloadItemList(

JNIEnv* env,

jobject j_result_obj,

const std::vector<const DownloadUIItem*>& items) {

- for (const auto item : items) {

+ for (auto* item : items) {

danakj 2017/02/28 15:33:29 const auto*?

vmpstr 2017/02/28 21:48:27 Done.

Java_OfflinePageDownloadBridge_createDownloadItemAndAddToList(

env, j_result_obj, ConvertUTF8ToJavaString(env, item->guid),

ConvertUTF8ToJavaString(env, item->url.spec()), item->download_state,