Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: chrome/browser/chromeos/printing/fake_printer_discoverer.cc

Issue 2721553004: Remove auto raw pointer deduction from non-linux specific code. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/preferences.cc ('k') | chrome/browser/mac/exception_processor.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/printing/fake_printer_discoverer.h" 5 #include "chrome/browser/chromeos/printing/fake_printer_discoverer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/threading/sequenced_task_runner_handle.h" 14 #include "base/threading/sequenced_task_runner_handle.h"
15 #include "base/time/time.h" 15 #include "base/time/time.h"
16 #include "chrome/browser/chromeos/printing/printer_discoverer.h" 16 #include "chrome/browser/chromeos/printing/printer_discoverer.h"
17 17
18 namespace chromeos { 18 namespace chromeos {
19 19
20 // static 20 // static
21 std::unique_ptr<PrinterDiscoverer> PrinterDiscoverer::Create() { 21 std::unique_ptr<PrinterDiscoverer> PrinterDiscoverer::Create() {
22 return base::MakeUnique<FakePrinterDiscoverer>(); 22 return base::MakeUnique<FakePrinterDiscoverer>();
23 } 23 }
24 24
25 FakePrinterDiscoverer::~FakePrinterDiscoverer() {} 25 FakePrinterDiscoverer::~FakePrinterDiscoverer() {}
26 26
27 bool FakePrinterDiscoverer::StartDiscovery() { 27 bool FakePrinterDiscoverer::StartDiscovery() {
28 discovery_running_ = true; 28 discovery_running_ = true;
29 29
30 for (auto observer : observers_) 30 for (auto* observer : observers_)
31 observer->OnDiscoveryStarted(); 31 observer->OnDiscoveryStarted();
32 32
33 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask( 33 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask(
34 FROM_HERE, base::Bind(&FakePrinterDiscoverer::EmitPrinters, 34 FROM_HERE, base::Bind(&FakePrinterDiscoverer::EmitPrinters,
35 weak_ptr_factory_.GetWeakPtr(), 0, 2), 35 weak_ptr_factory_.GetWeakPtr(), 0, 2),
36 base::TimeDelta::FromMilliseconds(2000)); 36 base::TimeDelta::FromMilliseconds(2000));
37 return true; 37 return true;
38 } 38 }
39 39
40 bool FakePrinterDiscoverer::StopDiscovery() { 40 bool FakePrinterDiscoverer::StopDiscovery() {
41 discovery_running_ = false; 41 discovery_running_ = false;
42 for (auto observer : observers_) 42 for (auto* observer : observers_)
43 observer->OnDiscoveryStopping(); 43 observer->OnDiscoveryStopping();
44 44
45 return true; 45 return true;
46 } 46 }
47 47
48 void FakePrinterDiscoverer::AddObserver(PrinterDiscoverer::Observer* observer) { 48 void FakePrinterDiscoverer::AddObserver(PrinterDiscoverer::Observer* observer) {
49 auto found = std::find(observers_.begin(), observers_.end(), observer); 49 auto found = std::find(observers_.begin(), observers_.end(), observer);
50 if (found == observers_.end()) 50 if (found == observers_.end())
51 observers_.push_back(observer); 51 observers_.push_back(observer);
52 } 52 }
(...skipping 25 matching lines...) Expand all
78 void FakePrinterDiscoverer::EmitPrinters(size_t start, size_t end) { 78 void FakePrinterDiscoverer::EmitPrinters(size_t start, size_t end) {
79 if (!discovery_running_ || start >= printers_.size() || end < start) 79 if (!discovery_running_ || start >= printers_.size() || end < start)
80 return; 80 return;
81 81
82 size_t clipped_start = std::max(static_cast<size_t>(0), start); 82 size_t clipped_start = std::max(static_cast<size_t>(0), start);
83 size_t clipped_end = std::min(printers_.size(), end); 83 size_t clipped_end = std::min(printers_.size(), end);
84 if (!observers_.empty()) { 84 if (!observers_.empty()) {
85 std::vector<Printer> subset(printers_.cbegin() + clipped_start, 85 std::vector<Printer> subset(printers_.cbegin() + clipped_start,
86 printers_.cbegin() + clipped_end); 86 printers_.cbegin() + clipped_end);
87 87
88 for (auto observer : observers_) 88 for (auto* observer : observers_)
89 observer->OnPrintersFound(subset); 89 observer->OnPrintersFound(subset);
90 } 90 }
91 91
92 // schedule another emit if elements remain. 92 // schedule another emit if elements remain.
93 if (end < printers_.size()) { 93 if (end < printers_.size()) {
94 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask( 94 base::SequencedTaskRunnerHandle::Get()->PostNonNestableDelayedTask(
95 FROM_HERE, 95 FROM_HERE,
96 base::Bind(&FakePrinterDiscoverer::EmitPrinters, 96 base::Bind(&FakePrinterDiscoverer::EmitPrinters,
97 weak_ptr_factory_.GetWeakPtr(), clipped_end, end + end), 97 weak_ptr_factory_.GetWeakPtr(), clipped_end, end + end),
98 base::TimeDelta::FromMilliseconds(2000)); 98 base::TimeDelta::FromMilliseconds(2000));
99 } else { 99 } else {
100 // We're done. Notify observers. 100 // We're done. Notify observers.
101 discovery_running_ = false; 101 discovery_running_ = false;
102 for (auto observer : observers_) 102 for (auto* observer : observers_)
103 observer->OnDiscoveryDone(); 103 observer->OnDiscoveryDone();
104 } 104 }
105 } 105 }
106 106
107 } // namespace chromeos 107 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/preferences.cc ('k') | chrome/browser/mac/exception_processor.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698