[turbofan] Make sure that CallIC feedback actually helps.

[turbofan] Make sure that CallIC feedback actually helps.

Don't just blindly bake in CallIC feedback in the JSCallReducer,
but instead try to estimate first whether it makes sense to bake
it in (and risk potential eager deoptimization exits). We already
didn't use the CallIC feedback when the call target is a known
constant, but we should also not use it if the target is a
JSCreateClosure node or a Phi of known constants / JSCreateClosure
nodes.

R=jarin@chromium.org
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2721483003
Cr-Commit-Position: refs/heads/master@{#43443}
Committed: https://chromium.googlesource.com/v8/v8/+/eb5f06dec8802b1376e7f86c1d56a825db0e9435

[Benedikt Meurer, 2017-02-27 09:24:35]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 09:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-02-27 09:37:22]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 09:37:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 10:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:02:13]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-02-27 10:12:25]

lgtm. Thanks!

[Benedikt Meurer, 2017-02-27 10:12:43]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:12:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 10:27:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488190363241850,
"parent_rev": "11e0f7810fada168b863be089459b4faebd5890f", "commit_rev":
"eb5f06dec8802b1376e7f86c1d56a825db0e9435"}

[commit-bot: I haz the power, 2017-02-27 10:27:56]

Description was changed from

==========
[turbofan] Make sure that CallIC feedback actually helps.

Don't just blindly bake in CallIC feedback in the JSCallReducer,
but instead try to estimate first whether it makes sense to bake
it in (and risk potential eager deoptimization exits). We already
didn't use the CallIC feedback when the call target is a known
constant, but we should also not use it if the target is a
JSCreateClosure node or a Phi of known constants / JSCreateClosure
nodes.

R=jarin@chromium.org
BUG=v8:5267
==========

to

==========
[turbofan] Make sure that CallIC feedback actually helps.

Don't just blindly bake in CallIC feedback in the JSCallReducer,
but instead try to estimate first whether it makes sense to bake
it in (and risk potential eager deoptimization exits). We already
didn't use the CallIC feedback when the call target is a known
constant, but we should also not use it if the target is a
JSCreateClosure node or a Phi of known constants / JSCreateClosure
nodes.

R=jarin@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2721483003
Cr-Commit-Position: refs/heads/master@{#43443}
Committed:
https://chromium.googlesource.com/v8/v8/+/eb5f06dec8802b1376e7f86c1d56a825db0...
==========

[commit-bot: I haz the power, 2017-02-27 10:27:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/eb5f06dec8802b1376e7f86c1d56a825db0...