Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2721463004: Added use counters for HTML[Embed | Object]Element getter and setter (Closed)

Created:
3 years, 9 months ago by lunalu1
Modified:
3 years, 9 months ago
Reviewers:
haraken, foolip
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added use counters for getter and setter in HTMLEmbedElement and HTMLObjectElement BUG=695895 Review-Url: https://codereview.chromium.org/2721463004 Cr-Commit-Position: refs/heads/master@{#453744} Committed: https://chromium.googlesource.com/chromium/src/+/e4ac2e9a324a943abe94c8161273904c53bc02b3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Codereview: nit #

Patch Set 3 : Rebase update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
lunalu1
3 years, 9 months ago (2017-02-27 21:23:05 UTC) #2
foolip
Changed the description to have the title all on one line, otherwise the resulting commit ...
3 years, 9 months ago (2017-02-28 04:37:07 UTC) #4
foolip
lgtm % nits https://codereview.chromium.org/2721463004/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp File third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp (right): https://codereview.chromium.org/2721463004/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp#newcode113 third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp:113: UseCounter::V8HTMLEmbedElement_getter); The V8* counters are all ...
3 years, 9 months ago (2017-02-28 04:38:22 UTC) #5
haraken
bindings LGTM
3 years, 9 months ago (2017-02-28 04:46:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721463004/20001
3 years, 9 months ago (2017-02-28 15:24:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/47043) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 15:27:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721463004/40001
3 years, 9 months ago (2017-02-28 20:19:00 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:42:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e4ac2e9a324a943abe94c8161273...

Powered by Google App Engine
This is Rietveld 408576698