Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2721343003: Remove redundant separator at end of the spelling correction context menu (Closed)

Created:
3 years, 9 months ago by edwardjung
Modified:
3 years, 9 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, govind
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove redundant separator at end of the spelling correction context menu In some editing cases (reporting a issue) inspect is not the last item. Review URL: https://codereview.chromium.org/2713333002 BUG=695800 NOTRY=true NOPRESUBMIT=true (cherry picked from commit 0f26be86266baa146ff07b69aace687393d8fc36) Review-Url: https://codereview.chromium.org/2721343003 Cr-Commit-Position: refs/branch-heads/2987@{#730} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/dc2bb753a4f87323a7d6473a6421d16f2e3da769

Patch Set 1 #

Patch Set 2 : Fix spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
edwardjung
@lazyboy, could you LGTM this merge to M58 branch 2987, I don't have commit access. ...
3 years, 9 months ago (2017-03-01 16:27:44 UTC) #3
lazyboy
lgtm
3 years, 9 months ago (2017-03-01 17:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721343003/20001
3 years, 9 months ago (2017-03-01 20:46:11 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 20:50:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc2bb753a4f87323a7d6473a6421...

Powered by Google App Engine
This is Rietveld 408576698