Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2721333007: [MD settings] edlide content exceptions (Closed)

Created:
3 years, 9 months ago by dschuyler
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] edlide content exceptions This CL will add ellipses to content settings exceptions that are too long to display. BUG=693176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2721333007 Cr-Commit-Position: refs/heads/master@{#454330} Committed: https://chromium.googlesource.com/chromium/src/+/7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896

Patch Set 1 #

Patch Set 2 : elide secondary line as well #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +3 lines, -4 lines 2 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 1 chunk +9 lines, -12 lines 2 comments Download

Messages

Total messages: 15 (11 generated)
dschuyler
https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resources/settings/settings_shared_css.html File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resources/settings/settings_shared_css.html#newcode141 chrome/browser/resources/settings/settings_shared_css.html:141: /* See also: .no-min-width below. */ Yeah, it's right ...
3 years, 9 months ago (2017-03-02 01:27:01 UTC) #7
tommycli
lgtm thanks https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resources/settings/settings_shared_css.html File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resources/settings/settings_shared_css.html#newcode141 chrome/browser/resources/settings/settings_shared_css.html:141: /* See also: .no-min-width below. */ On ...
3 years, 9 months ago (2017-03-02 16:36:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721333007/20001
3 years, 9 months ago (2017-03-02 19:12:14 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:18:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d4b75bd9a3d6cbda44aa98df49b...

Powered by Google App Engine
This is Rietveld 408576698