[MD settings] edlide content exceptions

[MD settings] edlide content exceptions

This CL will add ellipses to content settings exceptions that are too
long to display.

BUG=693176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2721333007
Cr-Commit-Position: refs/heads/master@{#454330}
Committed: https://chromium.googlesource.com/chromium/src/+/7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896

[dschuyler, 2017-03-02 01:17:19]

Description was changed from

==========
[MD settings] edlide content exceptions

This CL will add ellipses to content settings exceptions that are too
long to display.

BUG=693176
==========

to

==========
[MD settings] edlide content exceptions

This CL will add ellipses to content settings exceptions that are too
long to display.

BUG=693176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-02 01:17:21]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 01:17:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-02 01:20:41]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 01:21:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-02 01:27:00]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[dschuyler, 2017-03-02 01:27:01]

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:141: /* See also:
.no-min-width below. */
Yeah, it's right below this, but well, I didn't see it and re-solved the
problem. Then I looked to see if the fix was already in the code somewhere
before I added it (to avoid adding it redundantly), then saw that it was on line
152. I believe this comment will help future me as well as others.

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (left):

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:68: <div
class="start layout horizontal center" on-tap="onOriginTap_"
The .middle class shouldn't be inside of a .start class. The "layout horizontal
center" appears to be trying to work around the issues this causes. It's cleaner
to just remove the .start div and let the .middle handle the layout.

[commit-bot: I haz the power, 2017-03-02 02:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:57:22]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-03-02 16:36:02]

lgtm thanks

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:141: /* See also:
.no-min-width below. */
On 2017/03/02 01:27:01, dschuyler wrote:
> Yeah, it's right below this, but well, I didn't see it and re-solved the
> problem. Then I looked to see if the fix was already in the code somewhere
> before I added it (to avoid adding it redundantly), then saw that it was on
line
> 152. I believe this comment will help future me as well as others.

Acknowledged.

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (left):

https://codereview.chromium.org/2721333007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:68: <div
class="start layout horizontal center" on-tap="onOriginTap_"
On 2017/03/02 01:27:01, dschuyler wrote:
> The .middle class shouldn't be inside of a .start class. The "layout
horizontal
> center" appears to be trying to work around the issues this causes. It's
cleaner
> to just remove the .start div and let the .middle handle the layout.

Acknowledged.

[dschuyler, 2017-03-02 19:11:52]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:12:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:17:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488481912170800,
"parent_rev": "2f7781ce46951904a2615fbda44d2a9f4ced23ca", "commit_rev":
"7d4b75bd9a3d6cbda44aa98df49b7d7eb0a39896"}

[commit-bot: I haz the power, 2017-03-02 19:18:05]

Description was changed from

==========
[MD settings] edlide content exceptions

This CL will add ellipses to content settings exceptions that are too
long to display.

BUG=693176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] edlide content exceptions

This CL will add ellipses to content settings exceptions that are too
long to display.

BUG=693176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2721333007
Cr-Commit-Position: refs/heads/master@{#454330}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d4b75bd9a3d6cbda44aa98df49b...
==========

[commit-bot: I haz the power, 2017-03-02 19:18:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d4b75bd9a3d6cbda44aa98df49b...