Mac cert_verify_tool: add Security.framework library dep.

Mac cert_verify_tool: add Security.framework library dep.

Fixes clang build.

BUG=697615, 697603
Review-Url: https://codereview.chromium.org/2721313003
Cr-Commit-Position: refs/heads/master@{#454142}
Committed: https://chromium.googlesource.com/chromium/src/+/49957feee8c5ea46bc551e669e370164b6852702

[mattm, 2017-03-02 00:23:02]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 00:23:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-03-02 00:24:38]

mattm@chromium.org changed reviewers:
+ thakis@chromium.org

[Avi (use Gerrit), 2017-03-02 00:29:44]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2017-03-02 00:29:45]

LGTM, this fixes my linking issue reported in 697615.

[mattm, 2017-03-02 00:33:53]

The CQ bit was unchecked by mattm@chromium.org

[mattm, 2017-03-02 00:33:53]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 01:45:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488414833108830, "parent_rev":
"11266b8b9ebefbfc5ddb4156c194318ed2eb3a68", "commit_rev":
"49957feee8c5ea46bc551e669e370164b6852702"}

[commit-bot: I haz the power, 2017-03-02 01:46:23]

Description was changed from

==========
Mac cert_verify_tool: add Security.framework library dep.

Fixes clang build.

BUG=697615,697603
==========

to

==========
Mac cert_verify_tool: add Security.framework library dep.

Fixes clang build.

BUG=697615,697603

Review-Url: https://codereview.chromium.org/2721313003
Cr-Commit-Position: refs/heads/master@{#454142}
Committed:
https://chromium.googlesource.com/chromium/src/+/49957feee8c5ea46bc551e669e37...
==========

[commit-bot: I haz the power, 2017-03-02 01:46:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49957feee8c5ea46bc551e669e37...

[Nico, 2017-03-02 02:54:39]

Thanks. "Clang build" doesn't mean anything on Mac though, it's the only
build we have there.

On Mar 1, 2017 7:24 PM, <mattm@chromium.org> wrote:

> Reviewers: Nico
> CL: https://codereview.chromium.org/2721313003/
>
> Description:
> Mac cert_verify_tool: add Security.framework library dep.
>
> Fixes clang build.
>
> BUG=697615,697603
>
> Affected files (+4, -0 lines):
> M net/BUILD.gn
>
>
> Index: net/BUILD.gn
> diff --git a/net/BUILD.gn b/net/BUILD.gn
> index 64b9864a856a19198fef46fa442281156053fa47..
> cb075b74788871be18c19c9ede7c33036eeb0aa2 100644
> --- a/net/BUILD.gn
> +++ b/net/BUILD.gn
> @@ -2602,6 +2602,10 @@ if (!is_ios && !is_android) {
> "//build/config/sanitizers:deps",
> "//build/win:default_exe_manifest",
> ]
> +
> + if (is_mac) {
> + libs = [ "Security.framework" ]
> + }
> }
>
> executable("crash_cache") {
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mattm, 2017-03-02 02:55:46]

On 2017/03/02 02:54:39, Nico wrote:
> Thanks. "Clang build" doesn't mean anything on Mac though, it's the only
> build we have there.

Ah. I guess it must be static vs shared library build then.