Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2721313002: Notify ReadingListCollectionViewController during dismissal (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify ReadingListCollectionViewController during dismissal Make sure ReadingListCollectionViewController is notified when it is about to be dismissed after opening a link. BUG=697003 Review-Url: https://codereview.chromium.org/2721313002 Cr-Commit-Position: refs/heads/master@{#453914} Committed: https://chromium.googlesource.com/chromium/src/+/eaa4981576e913012f79990d3920956ecafd13fb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm View 8 chunks +26 lines, -9 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-01 09:01:52 UTC) #2
Olivier
lgtm https://codereview.chromium.org/2721313002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm File ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm (right): https://codereview.chromium.org/2721313002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm#newcode295 ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm:295: [readingListCollectionViewController willBeDismissed]; nit question: should this not be ...
3 years, 9 months ago (2017-03-01 09:42:17 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2721313002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm File ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm (right): https://codereview.chromium.org/2721313002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm#newcode295 ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm:295: [readingListCollectionViewController willBeDismissed]; On 2017/03/01 09:42:16, Olivier Robin wrote: ...
3 years, 9 months ago (2017-03-01 11:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721313002/1
3 years, 9 months ago (2017-03-01 11:59:56 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:11:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eaa4981576e913012f79990d3920...

Powered by Google App Engine
This is Rietveld 408576698