Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/module.json

Issue 2721233003: DevTools: create help sub-menu (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/module.json b/third_party/WebKit/Source/devtools/front_end/settings/module.json
index e4b274c5d4ee491fd8b107f38a290904bdd493d1..5e4bceec79c95d25b4a128bfd92fadb8780e9daa 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/settings/module.json
@@ -15,13 +15,6 @@
{
"type": "@UI.ActionDelegate",
"category": "Settings",
- "actionId": "settings.help",
alph 2017/03/01 17:26:47 why removing this?
chenwilliam 2017/03/01 19:43:26 I'm doing this imperatively in Main.js because I c
alph 2017/03/01 22:58:42 Hot sure about submenu, but could you please keep
chenwilliam 2017/03/02 00:26:20 Done.
- "title": "Help",
- "className": "Settings.SettingsScreen.ActionDelegate"
- },
- {
- "type": "@UI.ActionDelegate",
- "category": "Settings",
"actionId": "settings.shortcuts",
"title": "Shortcuts",
"className": "Settings.SettingsScreen.ActionDelegate"
@@ -44,12 +37,6 @@
"actionId": "settings.show"
},
{
- "type": "context-menu-item",
- "location": "mainMenu/footer",
- "order": 30,
- "actionId": "settings.help"
- },
- {
"type": "view",
"location": "settings-view",
"id": "preferences",

Powered by Google App Engine
This is Rietveld 408576698