Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2721163002: Add support for RTCConfiguration.iceCandidatePoolSize. (Closed)
Patch Set: Adding back log statement for test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
index 8fca4d0672815000bc07cdfeff1271ef0a498c14..62f8baebee4771415b037f6c9235097167c08ba8 100644
--- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
+++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
@@ -45,6 +45,11 @@ shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'}
shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'});");
shouldThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'});");
+shouldNotThrow("new RTCPeerConnection({iceCandidatePoolSize:1});");
foolip 2017/03/02 12:38:30 Also test 0? That's where an off-by-one bug is mos
Taylor_Brandstetter 2017/03/02 21:57:01 Done.
+shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:-1});");
+shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:99999999});");
+shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:'foo'});");
+
// Deprecated.
shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1}});");
shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");

Powered by Google App Engine
This is Rietveld 408576698