third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html - Issue 2721163002: Add support for RTCConfiguration.iceCandidatePoolSize.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2721163002: Add support for RTCConfiguration.iceCandidatePoolSize. (Closed)

Patch Set: Adding back log statement for test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt » ('j') | third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests the RTCPeerConnection constructor.");	8 description("Tests the RTCPeerConnection constructor.");

9	9

10 shouldBe("webkitRTCPeerConnection", "RTCPeerConnection");	10 shouldBe("webkitRTCPeerConnection", "RTCPeerConnection");

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); ");	39 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'balanced'}); ");

40 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'} );");	40 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-bundle'} );");

41 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'} );");	41 shouldNotThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'max-compat'} );");

42 shouldThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'foo'});");	42 shouldThrow("new RTCPeerConnection({iceServers:[], bundlePolicy:'foo'});");

43	43

44 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'} );");	44 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'negotiate'} );");

45 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); ");	45 shouldNotThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'require'}); ");

46 shouldThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'});");	46 shouldThrow("new RTCPeerConnection({iceServers:[], rtcpMuxPolicy:'foo'});");

47	47

	48 shouldNotThrow("new RTCPeerConnection({iceCandidatePoolSize:1});");
	foolip 2017/03/02 12:38:30 Also test 0? That's where an off-by-one bug is mos Also test 0? That's where an off-by-one bug is most likely I think. Taylor_Brandstetter 2017/03/02 21:57:01 Done. Show quoted text On 2017/03/02 12:38:30, foolip wrote: > Also test 0? That's where an off-by-one bug is most likely I think. Done.
	49 shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:-1});");

	50 shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:99999999});");

	51 shouldThrow("new RTCPeerConnection({iceCandidatePoolSize:'foo'});");

	52

48 // Deprecated.	53 // Deprecated.

49 shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1} });");	54 shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1} });");

50 shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");	55 shouldNotThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:1, valid_and_supported_2:1}});");

51 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_and_supported_1:0} ]});");	56 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_and_supported_1:0} ]});");

52 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_and_supported_1:0} ,{valid_and_supported_2:0}]});");	57 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_and_supported_1:0} ,{valid_and_supported_2:0}]});");

53 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_but_unsupported_1: 0},{valid_but_unsupported_2:0}]});");	58 shouldNotThrow("new RTCPeerConnection(null, {optional:[{valid_but_unsupported_1: 0},{valid_but_unsupported_2:0}]});");

54 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:66}}) ;");	59 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_and_supported_1:66}}) ;");

55 shouldThrow("new RTCPeerConnection(null, {mandatory:{invalid:1}});");	60 shouldThrow("new RTCPeerConnection(null, {mandatory:{invalid:1}});");

56 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1}} );");	61 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1}} );");

57 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1, valid_and_supported_1:1}});");	62 shouldThrow("new RTCPeerConnection(null, {mandatory:{valid_but_unsupported_1:1, valid_and_supported_1:1}});");

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
116 }	121 }

117 // Sequentially test construction with RSA and ECDSA certificates.	122 // Sequentially test construction with RSA and ECDSA certificates.

118 // testCertificates3Expired's callback methods mark the end of the async tests.	123 // testCertificates3Expired's callback methods mark the end of the async tests.

119 testCertificates1RSA();	124 testCertificates1RSA();

120	125

121 window.jsTestIsAsync = true;	126 window.jsTestIsAsync = true;

122 window.successfullyParsed = true;	127 window.successfullyParsed = true;

123 </script>	128 </script>

124 </body>	129 </body>

125 </html>	130 </html>

OLD	NEW