Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2721143002: [Cleanup] Clean up the MinidumpUploaderImpl code, mostly by updating comments. (Closed)

Created:
3 years, 9 months ago by Ilya Sherman
Modified:
3 years, 9 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, kalyank, sadrul, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Clean up the MinidumpUploaderImpl code, mostly by updating comments. BUG=694884 TEST=none R=tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2721143002 Cr-Commit-Position: refs/heads/master@{#453881} Committed: https://chromium.googlesource.com/chromium/src/+/cb2e1fe56fc33bde8b128817988e7b374ea7d1c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java View 6 chunks +53 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ilya Sherman
3 years, 9 months ago (2017-03-01 00:12:49 UTC) #1
Tobias Sargeant
On 2017/03/01 00:12:49, Ilya Sherman wrote: LGTM
3 years, 9 months ago (2017-03-01 07:57:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721143002/1
3 years, 9 months ago (2017-03-01 08:03:03 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:28:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb2e1fe56fc33bde8b128817988e...

Powered by Google App Engine
This is Rietveld 408576698