Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2721133006: Don't log deprecations in cross-origin iframe Indexed DB tests (Closed)

Created:
3 years, 9 months ago by jsbell
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, alexmos, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't log deprecations in cross-origin iframe Indexed DB tests Deprecation messages are only logged once per "page". With the --site-per-process flag set, iframes from different origins reside in different processes and don't share this information, so more messages may appear. Suppress the logging in tests where this occurs. BUG=697938 Review-Url: https://codereview.chromium.org/2721133006 Cr-Commit-Position: refs/heads/master@{#454362} Committed: https://chromium.googlesource.com/chromium/src/+/612c5c49898c0766cd07f65f95bc930e98210ef6

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
jsbell
lukasza@ - please take a look?
3 years, 9 months ago (2017-03-02 19:04:48 UTC) #2
Charlie Reis
lukasza@ is OOO, but this LGTM! Thanks for the quick update.
3 years, 9 months ago (2017-03-02 19:13:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133006/1
3 years, 9 months ago (2017-03-02 20:22:32 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 20:28:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/612c5c49898c0766cd07f65f95bc...

Powered by Google App Engine
This is Rietveld 408576698