Re-enable SecurityTest.CallocOverflow

Re-enable SecurityTest.CallocOverflow

The test now works after the fix to the Clang roll script in
r227545 and the Clang roll in r228318.

BUG=304125
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228508

[Nico, 2013-10-14 16:55:30]

lgtm


On Mon, Oct 14, 2013 at 9:54 AM, <hans@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> Re-enable SecurityTest.CallocOverflow
>
> The test now works after the fix to the Clang roll script in
> r227545 and the Clang roll in r228318.
>
> BUG=304125
>
> Please review this at
https://codereview.chromium.**org/27211002/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files (+1, -7 lines):
>   M base/security_unittest.cc
>
>
> Index: base/security_unittest.cc
> diff --git a/base/security_unittest.cc b/base/security_unittest.cc
> index 6c36d0d8e92bb4e2ad40b6a1aadbdd**2ea0a27094..**
> 8f5921973000fd935036f618a658f5**341b27c547 100644
> --- a/base/security_unittest.cc
> +++ b/base/security_unittest.cc
> @@ -213,13 +213,7 @@ bool CallocReturnsNull(size_t nmemb, size_t size) {
>  }
>
>  // Test if calloc() can overflow.
> -// Fails on Mac under ASAN. http://crbug.com/304125
> -#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
> -#define MAYBE_CallocOverflow DISABLED_CallocOverflow
> -#else
> -#define MAYBE_CallocOverflow CallocOverflow
> -#endif
> -TEST(SecurityTest, MAYBE_CallocOverflow) {
> +TEST(SecurityTest, CallocOverflow) {
>    const size_t kArraySize = 4096;
>    const size_t kMaxSizeT = numeric_limits<size_t>::max();
>    const size_t kArraySize2 = kMaxSizeT / kArraySize + 10;
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-14 16:58:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/27211002/1

[commit-bot: I haz the power, 2013-10-14 18:00:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/27211002/1

[commit-bot: I haz the power, 2013-10-14 19:37:14]

Change committed as 228508