Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2721083002: Move PwsClientImplTest to junit (Closed)

Created:
3 years, 9 months ago by cco3
Modified:
3 years, 9 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PwsClientImplTest to junit PwsClientImplTest does not need to be an instrumentation test, so this change moves it from javatests/ to junit/. In order to ease testing, this change also removes the constructor parameter from PwsClientImpl. BUG=696804 Review-Url: https://codereview.chromium.org/2721083002 Cr-Commit-Position: refs/heads/master@{#453811} Committed: https://chromium.googlesource.com/chromium/src/+/a7004210ac90b797a1dce103dcfb70bf1675add9

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -203 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/PwsClientImplTest.java View 1 chunk +0 lines, -163 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/physicalweb/PwsClientImplTest.java View 9 chunks +63 lines, -28 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
cco3
3 years, 9 months ago (2017-02-28 20:01:40 UTC) #2
mattreynolds
lgtm
3 years, 9 months ago (2017-02-28 20:18:44 UTC) #3
cco3
Hi Tommy, here's another one.
3 years, 9 months ago (2017-02-28 20:19:43 UTC) #5
nyquist
lgtm
3 years, 9 months ago (2017-02-28 22:48:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721083002/1
3 years, 9 months ago (2017-02-28 22:57:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/162036) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 23:00:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721083002/40001
3 years, 9 months ago (2017-03-01 00:39:32 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:10:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a7004210ac90b797a1dce103dcfb...

Powered by Google App Engine
This is Rietveld 408576698