Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2721023003: Add bsdiff to //build/install-build-deps-android.sh. (Closed)

Created:
3 years, 9 months ago by estevenson
Modified:
3 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bsdiff to //build/install-build-deps-android.sh. bsdiff is required for apk-patch-size-estimator to work, which will allow developers to check how their CLs affect patch size. BUG=695188 Review-Url: https://codereview.chromium.org/2721023003 Cr-Commit-Position: refs/heads/master@{#453936} Committed: https://chromium.googlesource.com/chromium/src/+/4c456252b3545304bd41c67a3c2379a12a3ec98f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/install-build-deps-android.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
estevenson
ptal Andrew!
3 years, 9 months ago (2017-02-28 22:49:22 UTC) #3
agrieve
On 2017/02/28 22:49:22, estevenson wrote: > ptal Andrew! lgtm
3 years, 9 months ago (2017-03-01 01:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721023003/1
3 years, 9 months ago (2017-03-01 15:10:08 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 15:22:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c456252b3545304bd41c67a3c23...

Powered by Google App Engine
This is Rietveld 408576698