Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2720973002: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)
Patch Set: Rebase after split Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
index 7e7fde4d558ba7f859856faf47a306013c66b1c4..5ca13f0193cf25b28ff093787b8f73c7ae601020 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
@@ -32,7 +32,6 @@
#define RemoteWindowProxy_h
#include "bindings/core/v8/DOMWrapperWorld.h"
-#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/WindowProxy.h"
#include "core/frame/RemoteFrame.h"
#include "v8/include/v8.h"
@@ -41,29 +40,14 @@
namespace blink {
// Subclass of WindowProxy that only handles RemoteFrame.
-// TODO(dcheng): This class currently duplicates a lot of logic from
-// LocalWindowPoxy:
-// - contextIfInitialized
-// - initialize
-// - disposeContext
-// - setupWindowPrototypeChain
-// - createContext
-// This is currently duplicated to make it easier to stage the switch to using
-// v8::RemoteContext::NewRemoteContext, and will be removed once the switch
-// is complete.
class RemoteWindowProxy final : public WindowProxy {
public:
static RemoteWindowProxy* create(v8::Isolate* isolate,
RemoteFrame& frame,
-
RefPtr<DOMWrapperWorld> world) {
return new RemoteWindowProxy(isolate, frame, std::move(world));
}
- v8::Local<v8::Context> contextIfInitialized() const {
- return m_scriptState ? m_scriptState->context() : v8::Local<v8::Context>();
- }
-
private:
RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);
@@ -79,8 +63,6 @@ class RemoteWindowProxy final : public WindowProxy {
// prototype chain do not get fully initialized yet, e.g. the window
// wrapper is not yet associated with the native DOMWindow object.
void createContext();
-
- RefPtr<ScriptState> m_scriptState;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698