Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2720963002: Make RenderViewContextMenuViews::GetBrowserAcceleratorProvider() work for GuestViews. (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
tapted, lazyboy, Matt Giuca
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RenderViewContextMenuViews::GetBrowserAcceleratorProvider() work for GuestViews. Thereby making F11 work for the PDF Viewer in the context menu. BUG=674108 Review-Url: https://codereview.chromium.org/2720963002 Cr-Commit-Position: refs/heads/master@{#453750} Committed: https://chromium.googlesource.com/chromium/src/+/6abab1a4e989e0675e2528750c381df3f6fb6287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Lei Zhang
+tapted since I have no idea how this affects MacViews.
3 years, 9 months ago (2017-02-28 06:53:39 UTC) #7
Matt Giuca
lgtm, thanks for this. I'll leave Trent (upgraded to reviewer) to comment on how this ...
3 years, 9 months ago (2017-02-28 07:43:35 UTC) #9
lazyboy
lgtm
3 years, 9 months ago (2017-02-28 18:39:11 UTC) #10
tapted
lgtm MacViews is still using RenderViewContextMenuMac for now (in fact mac_views_browser uses that too -- ...
3 years, 9 months ago (2017-02-28 22:54:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720963002/1
3 years, 9 months ago (2017-02-28 23:14:21 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:51:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6abab1a4e989e0675e2528750c38...

Powered by Google App Engine
This is Rietveld 408576698