Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2720953003: [unibrow] remove mongolian vowel separator as white space. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[unibrow] remove mongolian vowel separator as white space. Unibrow is currently at Unicode version 7.0.0, which does not include mongolian vowel separator (\u180E) as white space. In order to appease test262 at the time however we kept it as a whitespace. Test262 has since then been updated. And while this is not an update of unibrow, we are removing \u180E as white space here. R=jshin@chromium.org, littledan@chromium.org BUG=v8:5155 Review-Url: https://codereview.chromium.org/2720953003 Cr-Commit-Position: refs/heads/master@{#43485} Committed: https://chromium.googlesource.com/v8/v8/+/a5dfa06213d12fcabc014e6eacb73c199fd5a53e

Patch Set 1 #

Patch Set 2 : fix webkit test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M src/regexp/jsregexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/unicode.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/whitespaces.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -12 lines 0 comments Download
M test/unittests/char-predicates-unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/webkit/ToNumber-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/webkit/parseFloat-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
Yang
3 years, 9 months ago (2017-02-28 12:15:38 UTC) #1
Dan Ehrenberg
lgtm
3 years, 9 months ago (2017-02-28 12:18:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720953003/20001
3 years, 9 months ago (2017-02-28 13:40:51 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 13:42:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a5dfa06213d12fcabc014e6eacb73c199fd...

Powered by Google App Engine
This is Rietveld 408576698