Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2720933002: M57: Fix buffer overrun in PDF accessibility code. (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

M57: Fix buffer overrun in PDF accessibility code. GetTextRunInfo scans until it finds the start of the next text run, then increments the character index by 1 in order to scan to the end of the text run. That was resulting in a buffer ovverun if the first scan reached the end of the array of characters without finding a non-whitespace character. Fix it by ensuring we never increment past the char count. BUG=668724 Review-Url: https://codereview.chromium.org/2650513002 Cr-Commit-Position: refs/heads/master@{#447344} (cherry picked from commit e4e4b0140002c58d760bf8d9f3fcfd7d29343486) Review-Url: https://codereview.chromium.org/2720933002 . Cr-Commit-Position: refs/branch-heads/2987@{#707} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2da67ac9be739d36752e4b0c52c409d0a3bfec2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Lei Zhang
3 years, 9 months ago (2017-02-27 23:40:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2da67ac9be739d36752e4b0c52c409d0a3bfec2d.

Powered by Google App Engine
This is Rietveld 408576698