Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2720903003: MD History: Fix menu promo not hiding when menu button is clicked (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix menu promo not hiding when menu button is clicked BUG=696419 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2720903003 Cr-Commit-Position: refs/heads/master@{#453451} Committed: https://chromium.googlesource.com/chromium/src/+/2b2426cce14b23d2d91c363c1c65c0d38917b853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/resources/md_history/app.js View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tsergeant
3 years, 9 months ago (2017-02-27 23:33:00 UTC) #4
calamity
lgtm
3 years, 9 months ago (2017-02-28 01:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720903003/1
3 years, 9 months ago (2017-02-28 01:55:23 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:07:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b2426cce14b23d2d91c363c1c65...

Powered by Google App Engine
This is Rietveld 408576698