Fix lack of lock in MTTR::TakePendingTasks() and add a few more safety checks.

Fix lack of lock in MTTR::TakePendingTasks() and add a few more safety checks.

BUG=587199
Review-Url: https://codereview.chromium.org/2720903002
Cr-Commit-Position: refs/heads/master@{#454159}
Committed: https://chromium.googlesource.com/chromium/src/+/eebea688c3104b8e6633d74c7e313fca99e18a5b

[gab, 2017-02-27 20:38:03]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-02-27 20:38:57]

gab@chromium.org changed reviewers:
+ dcheng@chromium.org

[gab, 2017-02-27 20:38:57]

Daniel PTaL, tweaked this as part of writing
https://codereview.chromium.org/2657013002.

[commit-bot: I haz the power, 2017-02-27 20:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:42:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[gab, 2017-02-27 21:34:42]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 21:35:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 22:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:39:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dcheng, 2017-02-27 23:09:00]

The change LG but it seems like there a few unhappy bots, ping me again when the
bots are green?

[gab, 2017-02-28 18:18:31]

On 2017/02/27 23:09:00, dcheng wrote:
> The change LG but it seems like there a few unhappy bots, ping me again when
the
> bots are green?

Sorry unhappy bots are coming from CL this is based on
(https://codereview.chromium.org/2657013002#ps220001), this CL should be fine
once I fix that one.

[gab, 2017-03-01 02:31:27]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-03-01 02:54:48]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-03-01 02:55:07]

Patchset #3 (id:40001) has been deleted

[gab, 2017-03-01 02:57:36]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-03-01 03:00:10]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-03-01 03:01:02]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2017-03-01 03:04:04]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 03:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-01 03:12:29]

lgtm

[commit-bot: I haz the power, 2017-03-01 03:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 03:56:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-03-02 01:21:11]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-03-02 01:21:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 03:05:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488417671026190,
"parent_rev": "3270210250a02e082b0a376e0a900c73226c75c4", "commit_rev":
"eebea688c3104b8e6633d74c7e313fca99e18a5b"}

[commit-bot: I haz the power, 2017-03-02 03:05:58]

Description was changed from

==========
Fix lack of lock in MTTR::TakePendingTasks() and add a few more safety checks.

BUG=587199
==========

to

==========
Fix lack of lock in MTTR::TakePendingTasks() and add a few more safety checks.

BUG=587199

Review-Url: https://codereview.chromium.org/2720903002
Cr-Commit-Position: refs/heads/master@{#454159}
Committed:
https://chromium.googlesource.com/chromium/src/+/eebea688c3104b8e6633d74c7e31...
==========

[commit-bot: I haz the power, 2017-03-02 03:05:59]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/eebea688c3104b8e6633d74c7e31...