Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed

Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2720893003
Cr-Commit-Position: refs/heads/master@{#453487}
Committed: https://chromium.googlesource.com/chromium/src/+/08c892f77027cc70fd4a26bb218e88fe1e30161e

[Kevin M, 2017-02-27 22:29:16]

The CQ bit was checked by kmarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 22:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kevin M, 2017-02-27 22:33:18]

Description was changed from

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed.

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

This CL should be run with analysis FYI trybots.


BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org
==========

to

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed.

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
R=danakj@chromium.org
==========

[brucedawson, 2017-02-27 22:52:46]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2017-02-27 22:52:46]

lgtm

I confirmed that (ignoring white-space differences) this change is equivalent to
reverting these three recent changes, which seems correct:
549cad5d
9db26fb
e23eed0

[commit-bot: I haz the power, 2017-02-28 00:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 00:27:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2017-02-28 01:44:11]

Description was changed from

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed.

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
R=danakj@chromium.org
==========

to

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed.

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org
==========

[brucedawson, 2017-02-28 01:44:23]

Description was changed from

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed.

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org
==========

to

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org
==========

[brucedawson, 2017-02-28 01:45:13]

Failure appears spurious. kmarshall@ and danakj@ are unavailable at the moment
so I will try landing.

[brucedawson, 2017-02-28 01:45:26]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:46:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 03:46:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488246326388360, "parent_rev":
"9c4b5c2e2031c57553ef03b7077d0accd83e65c5", "commit_rev":
"08c892f77027cc70fd4a26bb218e88fe1e30161e"}

[commit-bot: I haz the power, 2017-02-28 03:47:01]

Description was changed from

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org
==========

to

==========
Roll back ANALYSIS_ASSUME_TRUE() until bitfield support is developed

The definition of AnalysisAssumeTrue() does not support bitfield
parameter types. This CL unblocks the Windows team from running
PREfast-analyze by rolling back the functionality. It will be relanded
when bitfields are supported.

BUG=687243
CC=brucedawson@chromium.org.
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2720893003
Cr-Commit-Position: refs/heads/master@{#453487}
Committed:
https://chromium.googlesource.com/chromium/src/+/08c892f77027cc70fd4a26bb218e...
==========

[commit-bot: I haz the power, 2017-02-28 03:47:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08c892f77027cc70fd4a26bb218e...