Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2720853004: Don't show paste option if can't paste (Closed)

Created:
3 years, 9 months ago by amaralp
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show paste option if can't paste If the clipboard is empty then the floating action mode should not have paste as an option. BUG=697144 Review-Url: https://codereview.chromium.org/2720853004 Cr-Commit-Position: refs/heads/master@{#453743} Committed: https://chromium.googlesource.com/chromium/src/+/b6a55f8d1df013355e9c5b52c3de13056c2c278f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
amaralp
PTAL
3 years, 9 months ago (2017-02-28 21:22:26 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-02-28 21:34:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720853004/1
3 years, 9 months ago (2017-02-28 22:52:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:41:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6a55f8d1df013355e9c5b52c3de...

Powered by Google App Engine
This is Rietveld 408576698