Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2720843003: Fix net-export bug on mobile where "contains private info" warning wasn't showing for "Include raw … (Closed)

Created:
3 years, 9 months ago by wangyix
Modified:
3 years, 9 months ago
Reviewers:
eroman, wangyix1
CC:
chromium-reviews, bnc+watch_chromium.org, mmenke, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net-export bug on mobile where "contains private info" warning wasn't showing for "Include raw bytes" mode. BUG=679122 Review-Url: https://codereview.chromium.org/2720843003 Cr-Commit-Position: refs/heads/master@{#453273} Committed: https://chromium.googlesource.com/chromium/src/+/00c650a3fbcdf8e850f336029b95f3a918a027df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/net_log/resources/net_export.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
wangyix1
PTAL
3 years, 9 months ago (2017-02-27 18:39:40 UTC) #2
eroman
lgtm
3 years, 9 months ago (2017-02-27 18:41:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720843003/1
3 years, 9 months ago (2017-02-27 18:44:18 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 18:56:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00c650a3fbcdf8e850f336029b95...

Powered by Google App Engine
This is Rietveld 408576698