Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2720833002: [MIPS64] Start using Clang IAS for mips64 Android (Closed)

Created:
3 years, 9 months ago by gordanac
Modified:
3 years, 9 months ago
Reviewers:
agrieve, gordanac
CC:
chromium-reviews, petar.jovanovic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS64] Start using Clang IAS for mips64 Android MIPS64 requires IAS to be explicitly set. Few important mips64 related changes were missing in Clang. With Clang roll to r295762 they are included and clang does not crash anymore. Now that build is ok we can switch to IAS as well. BUG=None. TEST=gn gen out-gn/mips64-clang --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" is_clang=true mips_use_msa=false" ninja -C out-gn/mips64-clang system_webview_apk Review-Url: https://codereview.chromium.org/2720833002 Cr-Commit-Position: refs/heads/master@{#453252} Committed: https://chromium.googlesource.com/chromium/src/+/55850d4e8fca1b77851f90956fe3dd995b01afc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
gordanac
Please take a look.
3 years, 9 months ago (2017-02-27 16:33:02 UTC) #2
agrieve
On 2017/02/27 16:33:02, gordanac wrote: > Please take a look. lgtm
3 years, 9 months ago (2017-02-27 16:56:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720833002/1
3 years, 9 months ago (2017-02-27 16:57:25 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 17:58:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55850d4e8fca1b77851f90956fe3...

Powered by Google App Engine
This is Rietveld 408576698