Pass returned resources to DidReceiveCompositorFrameAck

Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org,kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2720803002
Cr-Commit-Position: refs/heads/master@{#463798}
Committed: https://chromium.googlesource.com/chromium/src/+/8d3604f1b7aa64e24c3e98ba1f850da2d125b62e

[Saman Sami, 2017-02-27 16:02:07]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

BUG=682336
==========

to

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-27 16:02:09]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 16:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-02-27 16:07:33]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-02-27 16:07:58]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-02-27 16:09:11]

PTAL
I'm not sure how much you like this change. jbauman@ in my other CL wanted this
to happen.

[Fady Samuel, 2017-02-27 16:15:06]

I'm not a huge fan of this approach because we wanted to get rid of
DidReceiveCompositorFrameAck entirely
https://cs.chromium.org/chromium/src/cc/ipc/mojo_compositor_frame_sink.mojom?...

[commit-bot: I haz the power, 2017-02-27 17:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:17:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-03-08 16:44:28]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 16:44:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 16:47:28]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-04-11 18:29:48]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 18:55:16]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 18:55:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 18:56:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-11 19:13:44]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-11 19:19:31]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

Some clients of CompositorFrameSinkSupport such as DelegatedFrameHost
and RenderWidgetHostViewChildFrame have different behaviours based on 
whether the returned resources are accompanied by a frame ack or not.
So CompositorFrameSinkSupport should directly pass the returned resources
to DidReceiveCompositorFrameAck so that the client knows the resources
are returned with a swap ack.

BUG=682336
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 19:19:59]

PTAL

[Saman Sami, 2017-04-11 19:20:35]

fsamuel Who else do you want to review this? I'm thinking of TBRing everyone.

[Fady Samuel, 2017-04-11 19:32:56]

lgtm. Please pass this along to piman@ at least! Thanks

[commit-bot: I haz the power, 2017-04-11 19:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 19:33:53]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-04-11 19:44:18]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-04-11 19:44:30]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:44:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-11 19:53:30]

samans@chromium.org changed reviewers:
+ piman@chromium.org, tsepez@chromium.org

[Saman Sami, 2017-04-11 19:53:31]

piman PTAL
tsepez Please review IPC

[Tom Sepez, 2017-04-11 20:13:19]

lgtm

[Saman Sami, 2017-04-11 20:49:03]

Description was changed from

==========
DidReceiveCompositorFrameAck should take in ReturnedResources

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass ReturnedResources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 20:49:27]

Description was changed from

==========
Pass ReturnedResources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-04-11 21:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:18:27]

Dry run: This issue passed the CQ dry run.

[piman, 2017-04-11 21:41:50]

lgtm

https://codereview.chromium.org/2720803002/diff/100001/cc/ipc/mojo_compositor...
File cc/ipc/mojo_compositor_frame_sink.mojom (right):

https://codereview.chromium.org/2720803002/diff/100001/cc/ipc/mojo_compositor...
cc/ipc/mojo_compositor_frame_sink.mojom:55:
DidReceiveCompositorFrameAck(ReturnedResourceArray resources);
nit: this used to be the IPC version, and fsamuel had merged the corresponding
IPC into ReclaimResources, by adding a bool is_ack.

I really don't mind either way, just if you're looking for consistency (it may
make some adapters simpler).

[Saman Sami, 2017-04-11 21:50:22]

samans@chromium.org changed reviewers:
+ boliu@chromium.org

[Saman Sami, 2017-04-11 21:51:40]

samans@chromium.org changed reviewers:
+ derat@chromium.org

[Saman Sami, 2017-04-11 21:52:10]

Description was changed from

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 21:52:41]

Description was changed from

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 21:52:41]

samans@chromium.org changed reviewers:
+ reveman@chromium.org

[Saman Sami, 2017-04-11 21:54:13]

Description was changed from

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org,kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-04-11 21:54:13]

samans@chromium.org changed reviewers:
+ kbr@chromium.org

[Saman Sami, 2017-04-11 21:54:29]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-04-11 21:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2720803002/#ps100001
(title: "c")

[commit-bot: I haz the power, 2017-04-11 21:54:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-11 21:56:41]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-04-11 21:58:04]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:58:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-04-11 21:59:36]

lgtm

[commit-bot: I haz the power, 2017-04-11 22:15:35]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491947884410470,
"parent_rev": "974b5ce01edf7431419fd59151581fcaa8397dfd", "commit_rev":
"8d3604f1b7aa64e24c3e98ba1f850da2d125b62e"}

[commit-bot: I haz the power, 2017-04-11 22:16:30]

Description was changed from

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org,kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass returned resources to DidReceiveCompositorFrameAck

In order to minimize the number of IPC messages sent, it's better to
send frame ack and resources together if possible.

TBR=derat@chromium.org,boliu@chromium.org,reveman@chromium.org,kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2720803002
Cr-Commit-Position: refs/heads/master@{#463798}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d3604f1b7aa64e24c3e98ba1f85...
==========

[commit-bot: I haz the power, 2017-04-11 22:16:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8d3604f1b7aa64e24c3e98ba1f85...

[reveman, 2017-04-12 21:05:12]

FYI, this is causing the browser process on CrOS to crash when using the laser
pointer as LaserPointerView::ReclaimResources expects cc::ReturnedResourceArray
to be non-empty. Uploaded a fix: https://codereview.chromium.org/2812363002