Add Open my editor

Add Open my editor

OME is an tools for opening file in local editor by right click menu in
Chromium Code Search, Chromium Code Review and Chromium Build.

BUG=

Review-Url: https://codereview.chromium.org/2720793005
Cr-Commit-Position: refs/heads/master@{#454665}
Committed: https://chromium.googlesource.com/chromium/src/+/0d691b46e218d6cd559c58d06c0360d0cc048958

[chaopeng, 2017-02-28 19:26:28]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-02-28 19:26:35]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-02-28 19:26:55]

chaopeng@chromium.org changed reviewers:
+ thakis@chromium.org

[chaopeng, 2017-02-28 19:26:56]

PTAL, Thank you.

[Nico, 2017-03-02 15:47:11]

can you also add an OWNERS file and ideally find a second person to own this
together with you?

Generally this looks fine, but if possible it'd be good to use py2.7 like all
other .py files in the repo do

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
File
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py
(right):

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py:1:
#!/usr/bin/env python3
since this is only 40 lines, can you rewrite this in regular python 2.7? that's
what we bundle with depot_tools on windows and what all other scripts are in
– and it won't change much for this file anyhow

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
File tools/chrome_extensions/open_my_editor/myeditor-example/vscode-example.py
(right):

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
tools/chrome_extensions/open_my_editor/myeditor-example/vscode-example.py:1:
#!/usr/bin/env python3
same here

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
File tools/chrome_extensions/open_my_editor/omed.py (right):

https://codereview.chromium.org/2720793005/diff/1/tools/chrome_extensions/ope...
tools/chrome_extensions/open_my_editor/omed.py:1: #!/usr/bin/env python3
same here

[chaopeng, 2017-03-02 21:33:45]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[chaopeng, 2017-03-02 21:33:54]

The CQ bit was unchecked by chaopeng@chromium.org

[chaopeng, 2017-03-02 21:34:31]

chaopeng@chromium.org changed reviewers:
+ watk@chromium.org

[chaopeng, 2017-03-02 21:34:31]

Updated, PTAL. Thank you.

[watk, 2017-03-02 23:13:50]

Nice. I had to review this quickly, going OOO, so forgive me if my comments are
terse. 

In the commit message: s/openning/opening

Maybe add a bit of context to the commit title: "Add a developer tool: Open My
Editor".

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/README.md (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:3: OME is an enhance tools for
[Chromium Code Search](https://cs.chromium.org/),
"OME gives you a context menu for opening files in your editor on ..."

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:7: For Chromium Code Search,
right click on code block and select `OME`, it will
"on a code block"

OME -> "Open my editor"

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:8: open the file in your editor
with line number.
"at the selected line."

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:12: For chromium Code Search,
right click on symbol or filename and select
capitalize Chromium

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:13: `OME by link` can also open
file(maybe with linenumber).
Space before open paren.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:18: it will open all the files
in this patchset.
"this patchset" -> "the patchset"

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:22: For Chromium Code Review,
you can also right click on filename and select
"on a filename"

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:27: For any  *.chromium.org
site, select the file path then right click and select
Remove double space before *.chromium.org

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:32: 1. Install the Chrome
Extension `TODO will add link`
Finish todo now?

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:39: git clone
sso://user/chaopeng/ome ~/ome
Change this to the Chrome checkout version.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:40: python ~/ome/omed.py # you
should set it on startup
I would move this comment out of the code block into its own line and say
something like:

"It's convenient to configure your system to automatically run omed.py at
startup so that you don't have to remember to manually start it."

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:43: 4. Create your `myeditor`
as your editor's wrapper (see `myeditor-example/`) and
"Create a `myeditor` executable to be used for launching your editor, and add it
to your path. See `myeditor-example/`."

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/README.md:50: then make a http call to
`omed.py`. `omed.py` call `myeditor` to open your
"`omed.py` calls `myeditor`"

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/background.js (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/background.js:1: // Copyright 2017
Google Inc.
Is this Google copyright intended? Never seen this before.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/cr-content.js (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/cr-content.js:7: // For
codereview.chromium.org
Newline after. It looks like it's attached to the variable.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/cs-content.js (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/cs-content.js:12: //right click
Proper punctuation. Space after //.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/manifest.json (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/manifest.json:3: "description": "This
is a Chrome Extension allow your open current file on your editor from Chromium
Code Search and Code Review.",
"OME gives you a context menu for opening files in your editor on ..."

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py
(right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py:6:
'''
newline before this.

You might want to run these through pyformat if you haven't already. I don't
know our python style guide well so I can't comment on that.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py:32:
# I dont have a good idea to start a QtCreator instance, so please open it
nit: Here and in the rest of these sample files please add punctuation in
comments. (Periods at the end of sentences.)

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py:38:
# Open multi files
s/multi/multiple/

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/myeditor-example/vscode-example.py
(right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/vscode-example.py:6: '''
newline before

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/vscode-example.py:27: #
Here I start a vscode instance
delete "Here I".

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/omed.py (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/omed.py:6: '''
newline before

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/omed.py:7: Http Server handle file open
request
"HTTP server for handling requests to open files."

[watk, 2017-03-02 23:16:04]

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/background.js (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/background.js:65:
fetch('http://127.0.0.1:8989/files?f=' + res.files.join(','));
Did you consider that filenames can contain commas? I guess it's probably not a
concern in chrome, but something to be aware of.

[chaopeng, 2017-03-03 01:05:39]

Updated. PTAL. Thank you.

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/ext/background.js (right):

https://codereview.chromium.org/2720793005/diff/20001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/ext/background.js:65:
fetch('http://127.0.0.1:8989/files?f=' + res.files.join(','));
On 2017/03/02 23:16:04, watk wrote:
> Did you consider that filenames can contain commas? I guess it's probably not
a
> concern in chrome, but something to be aware of.

There is 2 files in chrome include ','. I changed it to ',,'.

[Nico, 2017-03-03 15:43:46]

lgtm once watk is happy.

(comment below applies to all 3 py files)

https://codereview.chromium.org/2720793005/diff/60001/tools/chrome_extensions...
File
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py
(right):

https://codereview.chromium.org/2720793005/diff/60001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/myeditor-example/qtcreator-example.py:1:
#!/usr/bin/env python2
just say `/usr/bin/env python`. that's what all our .py files say.

[chaopeng, 2017-03-03 16:09:24]

Description was changed from

==========
Add Open my editor

OME is an tools for openning file in local editor by right click menu in
Chromium Code Search, Chromium Code Review and Chromium Build.

BUG=
==========

to

==========
Add Open my editor

OME is an tools for opening file in local editor by right click menu in
Chromium Code Search, Chromium Code Review and Chromium Build.

BUG=
==========

[watk, 2017-03-03 19:57:49]

lgtm

[chaopeng, 2017-03-03 20:27:20]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-03-03 20:27:20]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2720793005/#ps80001
(title: "change python2 to python")

[commit-bot: I haz the power, 2017-03-03 20:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:47:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488572840612210,
"parent_rev": "699c0840f87b9839b04a7cca2805d890609e5cf6", "commit_rev":
"0d691b46e218d6cd559c58d06c0360d0cc048958"}

[commit-bot: I haz the power, 2017-03-03 20:48:22]

Description was changed from

==========
Add Open my editor

OME is an tools for opening file in local editor by right click menu in
Chromium Code Search, Chromium Code Review and Chromium Build.

BUG=
==========

to

==========
Add Open my editor

OME is an tools for opening file in local editor by right click menu in
Chromium Code Search, Chromium Code Review and Chromium Build.

BUG=

Review-Url: https://codereview.chromium.org/2720793005
Cr-Commit-Position: refs/heads/master@{#454665}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d691b46e218d6cd559c58d06c03...
==========

[commit-bot: I haz the power, 2017-03-03 20:48:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0d691b46e218d6cd559c58d06c03...

[Nico, 2017-03-22 16:13:45]

https://codereview.chromium.org/2720793005/diff/80001/tools/chrome_extensions...
File tools/chrome_extensions/open_my_editor/OWNERS (right):

https://codereview.chromium.org/2720793005/diff/80001/tools/chrome_extensions...
tools/chrome_extensions/open_my_editor/OWNERS:2: watk@chromium.org
The checked-in version of this file has only one owner, while this one has two.
What happened?

[Nico, 2017-03-22 16:14:43]

On 2017/03/22 16:13:45, Nico wrote:
>
https://codereview.chromium.org/2720793005/diff/80001/tools/chrome_extensions...
> File tools/chrome_extensions/open_my_editor/OWNERS (right):
> 
>
https://codereview.chromium.org/2720793005/diff/80001/tools/chrome_extensions...
> tools/chrome_extensions/open_my_editor/OWNERS:2: mailto:watk@chromium.org
> The checked-in version of this file has only one owner, while this one has
two.
> What happened?

Oh nevermind, the file just doesn't end in a newline, so the output was

thakis@thakis:~/src/chrome/src$ cat
tools/chrome_extensions/open_my_editor/OWNERS 
chaopeng@chromium.org
watk@chromium.orgthakis@thakis

and I missed the second line in front of my prompt.