Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2720793004: Add back the "Opening Links in Chrome" page to the sidenav. (Closed)

Created:
3 years, 9 months ago by jasonkliu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back the "Opening Links in Chrome" page to the sidenav. BUG=605237 Review-Url: https://codereview.chromium.org/2720793004 Cr-Commit-Position: refs/heads/master@{#461435} Committed: https://chromium.googlesource.com/chromium/src/+/0177c60721e1f13f4e2b8609c9fe9bde329a3f53

Patch Set 1 #

Patch Set 2 : Add iOS UA to the sidenav #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jasonkliu
3 years, 9 months ago (2017-02-27 23:44:14 UTC) #2
jasonkliu
+pink as committer (fyi)
3 years, 9 months ago (2017-02-27 23:44:45 UTC) #4
pink (ping after 24hrs)
lgtm
3 years, 9 months ago (2017-02-28 14:48:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720793004/1
3 years, 9 months ago (2017-02-28 14:48:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374568)
3 years, 9 months ago (2017-02-28 14:54:28 UTC) #9
mkearney1
lgtm
3 years, 8 months ago (2017-04-03 15:02:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720793004/20001
3 years, 8 months ago (2017-04-03 15:02:45 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 15:30:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0177c60721e1f13f4e2b8609c9fe...

Powered by Google App Engine
This is Rietveld 408576698