Adjust some tests to prepare enabling Ignition+TurboFan

Adjust some tests to prepare enabling Ignition+TurboFan

BUG=v8:5267, chromium:692409
Review-Url: https://codereview.chromium.org/2720713003
Cr-Commit-Position: refs/heads/master@{#43638}
Committed: https://chromium.googlesource.com/v8/v8/+/15bed19495e240db5f72a6ec6845ad5692950e80

[mvstanton, 2017-02-28 13:11:43]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 13:11:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 13:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 13:28:18]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-02-28 14:37:32]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 14:37:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 14:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:54:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-03-03 14:31:50]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 14:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 14:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:50:22]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/23556)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[mvstanton, 2017-03-03 14:55:06]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 14:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:53:37]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[mvstanton, 2017-03-06 14:01:37]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 14:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 14:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 14:18:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-03-06 14:36:18]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 14:36:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 15:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 15:04:49]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-03-07 09:22:21]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 09:22:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-07 09:23:31]

Description was changed from

==========
try --future.

BUG=
==========

to

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=
==========

[mvstanton, 2017-03-07 09:23:31]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:23:54]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/22093)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/21984)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36077)

[mvstanton, 2017-03-07 11:48:48]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 11:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-07 11:50:38]

Hi Michael, here is the CL we've discussed.
After your comments I'll reduce it to a single flag flip, and move the work
items to another CL to land first.
Thanks!
--Michael

[Michael Starzinger, 2017-03-07 11:54:33]

LGTM. Nice!

https://codereview.chromium.org/2720713003/diff/140001/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/2720713003/diff/140001/test/cctest/cctest.sta...
test/cctest/cctest.status:137: }],  # 'arch == arm64'
nit: Stray change.

https://codereview.chromium.org/2720713003/diff/160001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2720713003/diff/160001/src/flag-definitions.h...
src/flag-definitions.h:444: DEFINE_BOOL(turbo, true, "enable TurboFan compiler")
Yes, as discussed offline, lets separate the flag-flip out into a separate CL so
that it can easily be reverted without too much churn in the test directories.

[rmcilroy, 2017-03-07 12:23:13]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2017-03-07 12:24:31]

Also could you add the I+TF launch bug (chromium:692409) to the one which flips
the --turbo flag please.

https://codereview.chromium.org/2720713003/diff/160001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2720713003/diff/160001/src/flag-definitions.h...
src/flag-definitions.h:444: DEFINE_BOOL(turbo, true, "enable TurboFan compiler")
On 2017/03/07 11:54:33, Michael Starzinger wrote:
> Yes, as discussed offline, lets separate the flag-flip out into a separate CL
so
> that it can easily be reverted without too much churn in the test directories.

+1 :)

[mvstanton, 2017-03-07 12:52:24]

Description was changed from

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=
==========

to

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=v8:5267
==========

[mvstanton, 2017-03-07 12:52:49]

Description was changed from

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=v8:5267
==========

to

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=v8:5267, chromium:692409
==========

[mvstanton, 2017-03-07 13:01:03]

Description was changed from

==========
Set --turbo to true in builds. This enables the Ignition+TurboFan pipeline and
deprecates the FCG+Crankshaft pipeline.

BUG=v8:5267, chromium:692409
==========

to

==========
Adjust some tests to prepare enabling Ignition+TurboFan

BUG=v8:5267, chromium:692409
==========

[mvstanton, 2017-03-07 13:01:49]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2017-03-07 13:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2720713003/#ps180001
(title: "Turn off flag in this CL.")

[commit-bot: I haz the power, 2017-03-07 13:01:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-03-07 13:02:57]

Thanks guys. I've flipped the flag in this CL and will land these preparatory
changes...

https://codereview.chromium.org/2720713003/diff/140001/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/2720713003/diff/140001/test/cctest/cctest.sta...
test/cctest/cctest.status:137: }],  # 'arch == arm64'
On 2017/03/07 11:54:33, Michael Starzinger wrote:
> nit: Stray change.

Done.

[commit-bot: I haz the power, 2017-03-07 13:27:56]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1488891709614280,
"parent_rev": "e82b7ccd3211e226649c73148574c1967ba647e4", "commit_rev":
"15bed19495e240db5f72a6ec6845ad5692950e80"}

[commit-bot: I haz the power, 2017-03-07 13:28:03]

Description was changed from

==========
Adjust some tests to prepare enabling Ignition+TurboFan

BUG=v8:5267, chromium:692409
==========

to

==========
Adjust some tests to prepare enabling Ignition+TurboFan

BUG=v8:5267, chromium:692409

Review-Url: https://codereview.chromium.org/2720713003
Cr-Commit-Position: refs/heads/master@{#43638}
Committed:
https://chromium.googlesource.com/v8/v8/+/15bed19495e240db5f72a6ec6845ad56929...
==========

[commit-bot: I haz the power, 2017-03-07 13:28:04]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/15bed19495e240db5f72a6ec6845ad56929...