Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 27207003: Fix declaration vs. implementation ordering in NativeAppWindow{Views|Gtk} (Closed)

Created:
7 years, 2 months ago by James Cook
Modified:
7 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix declaration vs. implementation ordering in NativeAppWindow{Views|Gtk} This just reorders the functions in the NativeAppWindow interface. There are other ordering problems but they aren't worth fixing. Also move native_app_window.h into apps/ui/. BUG=306535 TEST=compiles TBR=benwells@chromium.org for file moves and trivial header path renames Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228848

Patch Set 1 #

Patch Set 2 : move native_app_window.h to ui #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -200 lines) Patch
M apps/app_shim/extension_app_shim_handler_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M apps/app_window_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/apps.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M apps/native_app_window.h View 1 1 chunk +0 lines, -71 lines 0 comments Download
M apps/shell_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/shell_window_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + apps/ui/native_app_window.h View 1 4 chunks +15 lines, -14 lines 0 comments Download
M apps/ui/views/shell_window_frame_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/apps/native_app_window_gtk.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/apps/native_app_window_gtk.cc View 3 chunks +42 lines, -42 lines 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 3 6 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
James Cook
Steven, PTAL This CL depends on https://codereview.chromium.org/27029006/ This doesn't fix everything, but leaves these files ...
7 years, 2 months ago (2013-10-14 22:33:12 UTC) #1
James Cook
actually, let me do one more thing in this CL first
7 years, 2 months ago (2013-10-14 22:35:22 UTC) #2
James Cook
Steven, now PTAL. I figured I could safely lump these two changes into one "move ...
7 years, 2 months ago (2013-10-14 22:52:29 UTC) #3
stevenjb
lgtm https://codereview.chromium.org/27207003/diff/6001/chrome/browser/ui/views/apps/native_app_window_views.cc File chrome/browser/ui/views/apps/native_app_window_views.cc (right): https://codereview.chromium.org/27207003/diff/6001/chrome/browser/ui/views/apps/native_app_window_views.cc#newcode839 chrome/browser/ui/views/apps/native_app_window_views.cc:839: void NativeAppWindowViews::HideWithApp() {} WS
7 years, 2 months ago (2013-10-14 23:20:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/27207003/6001
7 years, 2 months ago (2013-10-15 04:59:39 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-15 04:59:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/27207003/15001
7 years, 2 months ago (2013-10-15 17:30:13 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-15 17:41:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/27207003/15001
7 years, 2 months ago (2013-10-15 17:50:42 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests, interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=88922
7 years, 2 months ago (2013-10-15 23:35:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/27207003/41001
7 years, 2 months ago (2013-10-15 23:56:14 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 03:09:14 UTC) #12
Message was sent while issue was closed.
Change committed as 228848

Powered by Google App Engine
This is Rietveld 408576698